refactor(api, shared-data): liquid class tiprack schema change #18958
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbleon95
added
the
DO NOT MERGE
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## edge #18958 +/- ##
==========================================
- Coverage 56.24% 56.08% -0.17%
==========================================
Files 3342 3349 +7
Lines 288642 289637 +995
Branches 36922 36992 +70
==========================================
+ Hits 162356 162450 +94
- Misses 126084 126985 +901
Partials 202 202
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
ddcc4
reviewed
Jul 17, 2025
| ..., | ||
| description="The name of tiprack whose tip will be used" | ||
| " when handling this specific liquid class with this pipette" | ||
| ) |
There was a problem hiding this comment.
Nit: Move this down so that the entries here are ordered as liquidClassName, pipetteModel, tiprack; and update the comment below.
ddcc4
reviewed
Jul 17, 2025
| @@ -825,7 +825,7 @@ def minimal_liquid_class_def2() -> LiquidClassSchemaV1: | |||
| pipetteModel="flex_1channel_50", | |||
| byTipType=[ | |||
| ByTipTypeSetting( | |||
| tiprack="opentrons_flex_96_tiprack_50ul", | |||
| tiprack=["opentrons_flex_96_tiprack_50ul"], | |||
There was a problem hiding this comment.
I wonder how much more would break if you changed the name to tipracks to reflect its new type.
sanni-t
reviewed
Jul 18, 2025
Comment on lines
+57
to
+61
| # TODO having these refer to the same transfer property object | ||
| # but this may change IDK | ||
| transfer_props = build_transfer_properties(tip_type) | ||
| for tiprack in tip_type.tiprack: | ||
| tip_settings[tiprack] = transfer_props |
There was a problem hiding this comment.
Ya I think we should copy the transfer props instead of using the same, because otherwise multiple tipracks will have reference to the same transfer props object. This will cause problems like this-
props_for_v1_tiprack = water.get_for(pipette_load_name, "opentrons/opentrons_flex_96_tiprack_50ul/1")
props_for_v2_tiprack = water.get_for(pipette_load_name, "opentrons/opentrons_flex_96_tiprack_50ul/2")
assert props_for_v1_tiprack == props_for_v2_tiprack # passes
assert props_for_v1_tiprack.aspirate.submerge.speed == 100 # passes
props_for_v1_tiprack.aspirate.submerge.speed = 231
assert props_for_v2_tiprack.aspirate.submerge.speed == 231 # passes, not desirable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Test Plan and Hands on Testing
Changelog
Review requests
Risk assessment