fix(python): Do math on monotonic clocks only #19060
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
A lot of Python code (in various projects) was doing stuff like:
That's not quite right because
time.now()
can be affected by things like daylight savings time, leap seconds, and NTP adjustments. If we're doing math on timestamps, it needs to come from a monotonic clock. So this switches all (or at least most) of those places to usetime.monotonic()
instead.Test Plan and Hands on Testing
None.
Changelog
Basically a global Ctrl+F for
time.time()
. I replaced it withtime.monotonic()
when it was obvious to me that it was only used in the local scope and that math was being done on it. So this excludes things liketime()
calls that were getting saved in CSV reports.Review requests
OK with all the hardware-testing changes, or do I need to run that by anybody?
Risk assessment
Low. Changes are trivial.