Skip to content
Draft
Show file tree
Hide file tree
Changes from 17 commits
Commits
Show all changes
42 commits
Select commit Hold shift + click to select a range
22f2e2c
creating new location for labware images
rclarke0 Jul 30, 2025
58cb304
move images into shared-data
rclarke0 Jul 30, 2025
2239c7d
removing duplicate svgs
rclarke0 Jul 30, 2025
7cae0a1
fix lint errors
rclarke0 Jul 30, 2025
60a88ae
revert deleted file
rclarke0 Jul 30, 2025
3a1a358
pipfile
rclarke0 Jul 30, 2025
2e5004e
Merge branch 'edge' into relocate-labware-images
rclarke0 Jul 30, 2025
90dacf2
fix lint error in abr-testing folder
rclarke0 Jul 30, 2025
660495e
fix prettier errors
rclarke0 Jul 31, 2025
61ff951
prettier fix 2
rclarke0 Jul 31, 2025
0708c8f
prettier fix
rclarke0 Jul 31, 2025
824c774
add readme file
rclarke0 Aug 1, 2025
aa08e71
removing additional labwareimages.ts
rclarke0 Aug 1, 2025
f7b5f52
add test
rclarke0 Aug 1, 2025
afe9921
lint fix
rclarke0 Aug 1, 2025
24048ba
lint fixes
rclarke0 Aug 1, 2025
a647008
fix lint
rclarke0 Aug 1, 2025
53f96fa
fixes ot2 calibration bus
rclarke0 Aug 1, 2025
1b41de8
changed labware-images.ts to use glob and updated test case to check …
rclarke0 Aug 1, 2025
f5d6d20
prettier
rclarke0 Aug 4, 2025
88bd96a
updating images
rclarke0 Aug 5, 2025
0821c00
draft images
rclarke0 Aug 6, 2025
0865e73
changing some images
rclarke0 Aug 6, 2025
dff9107
labware images
rclarke0 Aug 6, 2025
a1fc4b8
Merge branch 'edge' into relocate-labware-images
rclarke0 Aug 6, 2025
7722b82
fix test
rclarke0 Aug 6, 2025
7588294
eppendorf labware
rclarke0 Aug 6, 2025
01e8547
change to local import statement
rclarke0 Aug 6, 2025
6f9c6b4
prettier fixes on README.md
rclarke0 Aug 7, 2025
0f0b925
combined labware-images.ts with labware.ts and resized images
rclarke0 Aug 8, 2025
34fa366
Merge branch 'edge' into relocate-labware-images
rclarke0 Aug 11, 2025
f37c950
abr-testing lint and format fixing
rclarke0 Aug 11, 2025
6156767
Merge branch 'edge' into relocate-labware-images
rclarke0 Aug 12, 2025
7e21840
Merge branch 'edge' into relocate-labware-images
rclarke0 Aug 25, 2025
6eb793c
fix(abr-testing): rever abr-testing changes
rclarke0 Aug 25, 2025
c763f24
fix(abr-testing): revert protocol changes
rclarke0 Aug 25, 2025
c40464b
refactor(shared-data): Increase visibility for labware image tools sc…
rclarke0 Aug 25, 2025
fec7852
refactor(shared-data): remove pillow package dependency
rclarke0 Aug 25, 2025
3b338e0
feat(shared-data): Test for properly formatted images.
rclarke0 Aug 25, 2025
a7455d5
fix(shard-data): Image size change.
rclarke0 Aug 25, 2025
3ffc07b
fix hard coded directory
rclarke0 Aug 26, 2025
ffa6adb
Draft changes to image editor
rclarke0 Aug 28, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file removed app/src/assets/images/labware/96-PCR-flat.png
Binary file not shown.
10 changes: 0 additions & 10 deletions app/src/assets/images/labware/circularWell.svg

This file was deleted.

Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
10 changes: 0 additions & 10 deletions app/src/assets/images/labware/rectangularWell.svg

This file was deleted.

Binary file not shown.
Binary file removed app/src/assets/images/labware/tiprack-200ul.png
Binary file not shown.
Binary file removed app/src/assets/images/labware/tiprack_multi.png
Binary file not shown.
Binary file removed app/src/assets/images/labware/tiprack_single.png
Binary file not shown.
Binary file removed app/src/assets/images/labware/trough-12row.png
Binary file not shown.
Binary file removed app/src/assets/images/labware/trough_multi.png
Binary file not shown.
Binary file removed app/src/assets/images/labware/trough_single.png
Binary file not shown.
Binary file removed app/src/assets/images/labware/tube-rack-2ml.png
Diff not rendered.
Binary file removed app/src/assets/images/labware/tuberack_single.png
Diff not rendered.
10 changes: 0 additions & 10 deletions app/src/assets/images/labware/wellShapeFlat.svg
Diff not rendered.
10 changes: 0 additions & 10 deletions app/src/assets/images/labware/wellShapeU.svg
Diff not rendered.
10 changes: 0 additions & 10 deletions app/src/assets/images/labware/wellShapeV.svg
Diff not rendered.
1 change: 0 additions & 1 deletion app/src/local-resources/labware/utils/index.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
export * from './getAllDefinitions'
export * from './labwareImages'
export * from './getAllDefs'
35 changes: 0 additions & 35 deletions app/src/local-resources/labware/utils/labwareImages.ts

This file was deleted.

4 changes: 2 additions & 2 deletions app/src/molecules/WizardRequiredEquipmentList/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@ import {
SPACING,
TYPOGRAPHY,
} from '@opentrons/components'
import { labwareImages } from '@opentrons/shared-data'

import { Divider } from '/app/atoms/structure'
import { labwareImages } from '/app/local-resources/labware'
import { getIsOnDevice } from '/app/redux/config'

import { equipmentImages } from './equipmentImages'
Expand Down Expand Up @@ -133,7 +133,7 @@ function RequiredEquipmentCard(props: RequiredEquipmentCardProps): JSX.Element {

let imageSrc: string | null = null
if (loadName in labwareImages) {
imageSrc = labwareImages[loadName as keyof typeof labwareImages]
imageSrc = labwareImages[loadName as keyof typeof labwareImages][0]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need some way to convey which image is "primary"? Or at least make sure the images are sorted in a deliberate way such that [0] is always "primary"?

You can imagine, like, a tip rack having a picture of the whole tip rack, and a separate picture of just a single tip. The prior behavior of this code was to show the whole tip rack, and we probably want to keep doing that. As-is, I don't think anything guarantees that we wouldn't accidentally show the single-tip picture.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It creates the list in alphabetical order so I don't think we need to

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed this to sort labwareImages

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the images are alphabetically sorted, and the "primary" image is the first image in this alphabetical list, can you expand the README to explain this behavior? Maybe note that the "primary" image should always be named the labware_load_name and any other images should have secondary text appended to the name

} else if (loadName in equipmentImages) {
imageSrc = equipmentImages[loadName as keyof typeof equipmentImages]
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@
SPACING,
TYPOGRAPHY,
} from '@opentrons/components'
import { labwareImages } from '@opentrons/shared-data'

import { getTopPortalEl } from '/app/App/portal'
import { labwareImages } from '/app/local-resources/labware'
import { WizardHeader } from '/app/molecules/WizardHeader'
import { setUseTrashSurfaceForTipCal } from '/app/redux/calibration'

Expand Down Expand Up @@ -96,7 +96,7 @@
<Flex flex="1" justifyContent={JUSTIFY_CENTER}>
<img
className={styles.block_image}
src={labwareImages[CAL_BLOCK_LOAD_NAME]}
src={labwareImages[CAL_BLOCK_LOAD_NAME][0]}

Check failure on line 99 in app/src/organisms/Desktop/CalibrateTipLength/AskForCalibrationBlockModal.tsx

View workflow job for this annotation

GitHub Actions / opentrons app frontend unit tests

app/src/organisms/Desktop/CalibrateTipLength/__tests__/AskForCalibrationBlockModal.test.tsx > AskForCalibrationBlockModal > does not save preference when not checked and use block is clicked

TypeError: Cannot read properties of undefined (reading '0') ❯ AskForCalibrationBlockModal app/src/organisms/Desktop/CalibrateTipLength/AskForCalibrationBlockModal.tsx:99:53 ❯ renderWithHooks node_modules/react-dom/cjs/react-dom.development.js:16305:18 ❯ mountIndeterminateComponent node_modules/react-dom/cjs/react-dom.development.js:20074:13 ❯ beginWork node_modules/react-dom/cjs/react-dom.development.js:21587:16 ❯ beginWork$1 node_modules/react-dom/cjs/react-dom.development.js:27426:14 ❯ performUnitOfWork node_modules/react-dom/cjs/react-dom.development.js:26560:12 ❯ workLoopSync node_modules/react-dom/cjs/react-dom.development.js:26466:5 ❯ renderRootSync node_modules/react-dom/cjs/react-dom.development.js:26434:7 ❯ recoverFromConcurrentError node_modules/react-dom/cjs/react-dom.development.js:25850:20 ❯ performConcurrentWorkOnRoot node_modules/react-dom/cjs/react-dom.development.js:25750:22

Check failure on line 99 in app/src/organisms/Desktop/CalibrateTipLength/AskForCalibrationBlockModal.tsx

View workflow job for this annotation

GitHub Actions / opentrons app frontend unit tests

app/src/organisms/Desktop/CalibrateTipLength/__tests__/AskForCalibrationBlockModal.test.tsx > AskForCalibrationBlockModal > saves preference when not checked and use block is clicked

TypeError: Cannot read properties of undefined (reading '0') ❯ AskForCalibrationBlockModal app/src/organisms/Desktop/CalibrateTipLength/AskForCalibrationBlockModal.tsx:99:53 ❯ renderWithHooks node_modules/react-dom/cjs/react-dom.development.js:16305:18 ❯ mountIndeterminateComponent node_modules/react-dom/cjs/react-dom.development.js:20074:13 ❯ beginWork node_modules/react-dom/cjs/react-dom.development.js:21587:16 ❯ beginWork$1 node_modules/react-dom/cjs/react-dom.development.js:27426:14 ❯ performUnitOfWork node_modules/react-dom/cjs/react-dom.development.js:26560:12 ❯ workLoopSync node_modules/react-dom/cjs/react-dom.development.js:26466:5 ❯ renderRootSync node_modules/react-dom/cjs/react-dom.development.js:26434:7 ❯ recoverFromConcurrentError node_modules/react-dom/cjs/react-dom.development.js:25850:20 ❯ performConcurrentWorkOnRoot node_modules/react-dom/cjs/react-dom.development.js:25750:22

Check failure on line 99 in app/src/organisms/Desktop/CalibrateTipLength/AskForCalibrationBlockModal.tsx

View workflow job for this annotation

GitHub Actions / opentrons app frontend unit tests

app/src/organisms/Desktop/CalibrateTipLength/__tests__/AskForCalibrationBlockModal.test.tsx > AskForCalibrationBlockModal > does not save preference when not checked and use trash is clicked

TypeError: Cannot read properties of undefined (reading '0') ❯ AskForCalibrationBlockModal app/src/organisms/Desktop/CalibrateTipLength/AskForCalibrationBlockModal.tsx:99:53 ❯ renderWithHooks node_modules/react-dom/cjs/react-dom.development.js:16305:18 ❯ mountIndeterminateComponent node_modules/react-dom/cjs/react-dom.development.js:20074:13 ❯ beginWork node_modules/react-dom/cjs/react-dom.development.js:21587:16 ❯ beginWork$1 node_modules/react-dom/cjs/react-dom.development.js:27426:14 ❯ performUnitOfWork node_modules/react-dom/cjs/react-dom.development.js:26560:12 ❯ workLoopSync node_modules/react-dom/cjs/react-dom.development.js:26466:5 ❯ renderRootSync node_modules/react-dom/cjs/react-dom.development.js:26434:7 ❯ recoverFromConcurrentError node_modules/react-dom/cjs/react-dom.development.js:25850:20 ❯ performConcurrentWorkOnRoot node_modules/react-dom/cjs/react-dom.development.js:25750:22

Check failure on line 99 in app/src/organisms/Desktop/CalibrateTipLength/AskForCalibrationBlockModal.tsx

View workflow job for this annotation

GitHub Actions / opentrons app frontend unit tests

app/src/organisms/Desktop/CalibrateTipLength/__tests__/AskForCalibrationBlockModal.test.tsx > AskForCalibrationBlockModal > saves preference when not checked and use trash is clicked

TypeError: Cannot read properties of undefined (reading '0') ❯ AskForCalibrationBlockModal app/src/organisms/Desktop/CalibrateTipLength/AskForCalibrationBlockModal.tsx:99:53 ❯ renderWithHooks node_modules/react-dom/cjs/react-dom.development.js:16305:18 ❯ mountIndeterminateComponent node_modules/react-dom/cjs/react-dom.development.js:20074:13 ❯ beginWork node_modules/react-dom/cjs/react-dom.development.js:21587:16 ❯ beginWork$1 node_modules/react-dom/cjs/react-dom.development.js:27426:14 ❯ performUnitOfWork node_modules/react-dom/cjs/react-dom.development.js:26560:12 ❯ workLoopSync node_modules/react-dom/cjs/react-dom.development.js:26466:5 ❯ renderRootSync node_modules/react-dom/cjs/react-dom.development.js:26434:7 ❯ recoverFromConcurrentError node_modules/react-dom/cjs/react-dom.development.js:25850:20 ❯ performConcurrentWorkOnRoot node_modules/react-dom/cjs/react-dom.development.js:25750:22

Check failure on line 99 in app/src/organisms/Desktop/CalibrateTipLength/AskForCalibrationBlockModal.tsx

View workflow job for this annotation

GitHub Actions / opentrons app frontend unit tests

app/src/organisms/Desktop/CalibrateTipLength/__tests__/AskForCalibrationBlockModal.test.tsx > AskForCalibrationBlockModal > does not save preference when not checked and use block is clicked

TypeError: Cannot read properties of undefined (reading '0') ❯ AskForCalibrationBlockModal app/src/organisms/Desktop/CalibrateTipLength/AskForCalibrationBlockModal.tsx:99:53 ❯ renderWithHooks node_modules/react-dom/cjs/react-dom.development.js:16305:18 ❯ mountIndeterminateComponent node_modules/react-dom/cjs/react-dom.development.js:20074:13 ❯ beginWork node_modules/react-dom/cjs/react-dom.development.js:21587:16 ❯ beginWork$1 node_modules/react-dom/cjs/react-dom.development.js:27426:14 ❯ performUnitOfWork node_modules/react-dom/cjs/react-dom.development.js:26560:12 ❯ workLoopSync node_modules/react-dom/cjs/react-dom.development.js:26466:5 ❯ renderRootSync node_modules/react-dom/cjs/react-dom.development.js:26434:7 ❯ recoverFromConcurrentError node_modules/react-dom/cjs/react-dom.development.js:25850:20 ❯ performConcurrentWorkOnRoot node_modules/react-dom/cjs/react-dom.development.js:25750:22

Check failure on line 99 in app/src/organisms/Desktop/CalibrateTipLength/AskForCalibrationBlockModal.tsx

View workflow job for this annotation

GitHub Actions / opentrons app frontend unit tests

app/src/organisms/Desktop/CalibrateTipLength/__tests__/AskForCalibrationBlockModal.test.tsx > AskForCalibrationBlockModal > saves preference when not checked and use block is clicked

TypeError: Cannot read properties of undefined (reading '0') ❯ AskForCalibrationBlockModal app/src/organisms/Desktop/CalibrateTipLength/AskForCalibrationBlockModal.tsx:99:53 ❯ renderWithHooks node_modules/react-dom/cjs/react-dom.development.js:16305:18 ❯ mountIndeterminateComponent node_modules/react-dom/cjs/react-dom.development.js:20074:13 ❯ beginWork node_modules/react-dom/cjs/react-dom.development.js:21587:16 ❯ beginWork$1 node_modules/react-dom/cjs/react-dom.development.js:27426:14 ❯ performUnitOfWork node_modules/react-dom/cjs/react-dom.development.js:26560:12 ❯ workLoopSync node_modules/react-dom/cjs/react-dom.development.js:26466:5 ❯ renderRootSync node_modules/react-dom/cjs/react-dom.development.js:26434:7 ❯ recoverFromConcurrentError node_modules/react-dom/cjs/react-dom.development.js:25850:20 ❯ performConcurrentWorkOnRoot node_modules/react-dom/cjs/react-dom.development.js:25750:22

Check failure on line 99 in app/src/organisms/Desktop/CalibrateTipLength/AskForCalibrationBlockModal.tsx

View workflow job for this annotation

GitHub Actions / opentrons app frontend unit tests

app/src/organisms/Desktop/CalibrateTipLength/__tests__/AskForCalibrationBlockModal.test.tsx > AskForCalibrationBlockModal > does not save preference when not checked and use trash is clicked

TypeError: Cannot read properties of undefined (reading '0') ❯ AskForCalibrationBlockModal app/src/organisms/Desktop/CalibrateTipLength/AskForCalibrationBlockModal.tsx:99:53 ❯ renderWithHooks node_modules/react-dom/cjs/react-dom.development.js:16305:18 ❯ mountIndeterminateComponent node_modules/react-dom/cjs/react-dom.development.js:20074:13 ❯ beginWork node_modules/react-dom/cjs/react-dom.development.js:21587:16 ❯ beginWork$1 node_modules/react-dom/cjs/react-dom.development.js:27426:14 ❯ performUnitOfWork node_modules/react-dom/cjs/react-dom.development.js:26560:12 ❯ workLoopSync node_modules/react-dom/cjs/react-dom.development.js:26466:5 ❯ renderRootSync node_modules/react-dom/cjs/react-dom.development.js:26434:7 ❯ recoverFromConcurrentError node_modules/react-dom/cjs/react-dom.development.js:25850:20 ❯ performConcurrentWorkOnRoot node_modules/react-dom/cjs/react-dom.development.js:25750:22

Check failure on line 99 in app/src/organisms/Desktop/CalibrateTipLength/AskForCalibrationBlockModal.tsx

View workflow job for this annotation

GitHub Actions / opentrons app frontend unit tests

app/src/organisms/Desktop/CalibrateTipLength/__tests__/AskForCalibrationBlockModal.test.tsx > AskForCalibrationBlockModal > saves preference when not checked and use trash is clicked

TypeError: Cannot read properties of undefined (reading '0') ❯ AskForCalibrationBlockModal app/src/organisms/Desktop/CalibrateTipLength/AskForCalibrationBlockModal.tsx:99:53 ❯ renderWithHooks node_modules/react-dom/cjs/react-dom.development.js:16305:18 ❯ mountIndeterminateComponent node_modules/react-dom/cjs/react-dom.development.js:20074:13 ❯ beginWork node_modules/react-dom/cjs/react-dom.development.js:21587:16 ❯ beginWork$1 node_modules/react-dom/cjs/react-dom.development.js:27426:14 ❯ performUnitOfWork node_modules/react-dom/cjs/react-dom.development.js:26560:12 ❯ workLoopSync node_modules/react-dom/cjs/react-dom.development.js:26466:5 ❯ renderRootSync node_modules/react-dom/cjs/react-dom.development.js:26434:7 ❯ recoverFromConcurrentError node_modules/react-dom/cjs/react-dom.development.js:25850:20 ❯ performConcurrentWorkOnRoot node_modules/react-dom/cjs/react-dom.development.js:25750:22
/>
</Flex>
</Flex>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,7 @@
LegacyStyledText,
SPACING,
} from '@opentrons/components'

import { labwareImages } from '/app/local-resources/labware'
import { labwareImages } from '@opentrons/shared-data'

import type { SelectOption } from '@opentrons/components'

Expand Down Expand Up @@ -41,7 +40,7 @@
max-width: 7rem;
max-height: 3.7rem;
`}
src={imageSrc}
src={imageSrc[0]}

Check failure on line 43 in app/src/organisms/Desktop/CalibrationPanels/ChosenTipRackRender.tsx

View workflow job for this annotation

GitHub Actions / opentrons app frontend unit tests

app/src/organisms/Desktop/CalibrationPanels/__tests__/ChosenTipRackRender.test.tsx > ChosenTipRackRender > renders text and image alt text when tip rack is Opentrons 96 1000uL

TypeError: Cannot read properties of undefined (reading '0') ❯ ChosenTipRackRender app/src/organisms/Desktop/CalibrationPanels/ChosenTipRackRender.tsx:43:14 ❯ renderWithHooks node_modules/react-dom/cjs/react-dom.development.js:16305:18 ❯ mountIndeterminateComponent node_modules/react-dom/cjs/react-dom.development.js:20074:13 ❯ beginWork node_modules/react-dom/cjs/react-dom.development.js:21587:16 ❯ beginWork$1 node_modules/react-dom/cjs/react-dom.development.js:27426:14 ❯ performUnitOfWork node_modules/react-dom/cjs/react-dom.development.js:26560:12 ❯ workLoopSync node_modules/react-dom/cjs/react-dom.development.js:26466:5 ❯ renderRootSync node_modules/react-dom/cjs/react-dom.development.js:26434:7 ❯ recoverFromConcurrentError node_modules/react-dom/cjs/react-dom.development.js:25850:20 ❯ performConcurrentWorkOnRoot node_modules/react-dom/cjs/react-dom.development.js:25750:22

Check failure on line 43 in app/src/organisms/Desktop/CalibrationPanels/ChosenTipRackRender.tsx

View workflow job for this annotation

GitHub Actions / opentrons app frontend unit tests

app/src/organisms/Desktop/CalibrationPanels/__tests__/ChooseTipRack.test.tsx > ChooseTipRack > renders the buttons and they work as expected

TypeError: Cannot read properties of undefined (reading '0') ❯ ChosenTipRackRender app/src/organisms/Desktop/CalibrationPanels/ChosenTipRackRender.tsx:43:14 ❯ renderWithHooks node_modules/react-dom/cjs/react-dom.development.js:16305:18 ❯ mountIndeterminateComponent node_modules/react-dom/cjs/react-dom.development.js:20074:13 ❯ beginWork node_modules/react-dom/cjs/react-dom.development.js:21587:16 ❯ beginWork$1 node_modules/react-dom/cjs/react-dom.development.js:27426:14 ❯ performUnitOfWork node_modules/react-dom/cjs/react-dom.development.js:26560:12 ❯ workLoopSync node_modules/react-dom/cjs/react-dom.development.js:26466:5 ❯ renderRootSync node_modules/react-dom/cjs/react-dom.development.js:26434:7 ❯ recoverFromConcurrentError node_modules/react-dom/cjs/react-dom.development.js:25850:20 ❯ performConcurrentWorkOnRoot node_modules/react-dom/cjs/react-dom.development.js:25750:22

Check failure on line 43 in app/src/organisms/Desktop/CalibrationPanels/ChosenTipRackRender.tsx

View workflow job for this annotation

GitHub Actions / opentrons app frontend unit tests

app/src/organisms/Desktop/CalibrationPanels/__tests__/ChooseTipRack.test.tsx > ChooseTipRack > renders the correct text

TypeError: Cannot read properties of undefined (reading '0') ❯ ChosenTipRackRender app/src/organisms/Desktop/CalibrationPanels/ChosenTipRackRender.tsx:43:14 ❯ renderWithHooks node_modules/react-dom/cjs/react-dom.development.js:16305:18 ❯ mountIndeterminateComponent node_modules/react-dom/cjs/react-dom.development.js:20074:13 ❯ beginWork node_modules/react-dom/cjs/react-dom.development.js:21587:16 ❯ beginWork$1 node_modules/react-dom/cjs/react-dom.development.js:27426:14 ❯ performUnitOfWork node_modules/react-dom/cjs/react-dom.development.js:26560:12 ❯ workLoopSync node_modules/react-dom/cjs/react-dom.development.js:26466:5 ❯ renderRootSync node_modules/react-dom/cjs/react-dom.development.js:26434:7 ❯ recoverFromConcurrentError node_modules/react-dom/cjs/react-dom.development.js:25850:20 ❯ performConcurrentWorkOnRoot node_modules/react-dom/cjs/react-dom.development.js:25750:22

Check failure on line 43 in app/src/organisms/Desktop/CalibrationPanels/ChosenTipRackRender.tsx

View workflow job for this annotation

GitHub Actions / opentrons app frontend unit tests

app/src/organisms/Desktop/CalibrationPanels/__tests__/ChosenTipRackRender.test.tsx > ChosenTipRackRender > renders text and image alt text when tip rack is Opentrons 96 1000uL

TypeError: Cannot read properties of undefined (reading '0') ❯ ChosenTipRackRender app/src/organisms/Desktop/CalibrationPanels/ChosenTipRackRender.tsx:43:14 ❯ renderWithHooks node_modules/react-dom/cjs/react-dom.development.js:16305:18 ❯ mountIndeterminateComponent node_modules/react-dom/cjs/react-dom.development.js:20074:13 ❯ beginWork node_modules/react-dom/cjs/react-dom.development.js:21587:16 ❯ beginWork$1 node_modules/react-dom/cjs/react-dom.development.js:27426:14 ❯ performUnitOfWork node_modules/react-dom/cjs/react-dom.development.js:26560:12 ❯ workLoopSync node_modules/react-dom/cjs/react-dom.development.js:26466:5 ❯ renderRootSync node_modules/react-dom/cjs/react-dom.development.js:26434:7 ❯ recoverFromConcurrentError node_modules/react-dom/cjs/react-dom.development.js:25850:20 ❯ performConcurrentWorkOnRoot node_modules/react-dom/cjs/react-dom.development.js:25750:22

Check failure on line 43 in app/src/organisms/Desktop/CalibrationPanels/ChosenTipRackRender.tsx

View workflow job for this annotation

GitHub Actions / opentrons app frontend unit tests

app/src/organisms/Desktop/CalibrationPanels/__tests__/ChooseTipRack.test.tsx > ChooseTipRack > renders the buttons and they work as expected

TypeError: Cannot read properties of undefined (reading '0') ❯ ChosenTipRackRender app/src/organisms/Desktop/CalibrationPanels/ChosenTipRackRender.tsx:43:14 ❯ renderWithHooks node_modules/react-dom/cjs/react-dom.development.js:16305:18 ❯ mountIndeterminateComponent node_modules/react-dom/cjs/react-dom.development.js:20074:13 ❯ beginWork node_modules/react-dom/cjs/react-dom.development.js:21587:16 ❯ beginWork$1 node_modules/react-dom/cjs/react-dom.development.js:27426:14 ❯ performUnitOfWork node_modules/react-dom/cjs/react-dom.development.js:26560:12 ❯ workLoopSync node_modules/react-dom/cjs/react-dom.development.js:26466:5 ❯ renderRootSync node_modules/react-dom/cjs/react-dom.development.js:26434:7 ❯ recoverFromConcurrentError node_modules/react-dom/cjs/react-dom.development.js:25850:20 ❯ performConcurrentWorkOnRoot node_modules/react-dom/cjs/react-dom.development.js:25750:22

Check failure on line 43 in app/src/organisms/Desktop/CalibrationPanels/ChosenTipRackRender.tsx

View workflow job for this annotation

GitHub Actions / opentrons app frontend unit tests

app/src/organisms/Desktop/CalibrationPanels/__tests__/ChooseTipRack.test.tsx > ChooseTipRack > renders the correct text

TypeError: Cannot read properties of undefined (reading '0') ❯ ChosenTipRackRender app/src/organisms/Desktop/CalibrationPanels/ChosenTipRackRender.tsx:43:14 ❯ renderWithHooks node_modules/react-dom/cjs/react-dom.development.js:16305:18 ❯ mountIndeterminateComponent node_modules/react-dom/cjs/react-dom.development.js:20074:13 ❯ beginWork node_modules/react-dom/cjs/react-dom.development.js:21587:16 ❯ beginWork$1 node_modules/react-dom/cjs/react-dom.development.js:27426:14 ❯ performUnitOfWork node_modules/react-dom/cjs/react-dom.development.js:26560:12 ❯ workLoopSync node_modules/react-dom/cjs/react-dom.development.js:26466:5 ❯ renderRootSync node_modules/react-dom/cjs/react-dom.development.js:26434:7 ❯ recoverFromConcurrentError node_modules/react-dom/cjs/react-dom.development.js:25850:20 ❯ performConcurrentWorkOnRoot node_modules/react-dom/cjs/react-dom.development.js:25750:22
alt={`${String(displayName)} image`}
/>
<Box>
Expand Down
4 changes: 1 addition & 3 deletions app/src/organisms/Desktop/Labware/LabwareDetails/Gallery.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,7 @@ import {
SPACING,
SPACING_AUTO,
} from '@opentrons/components'
import { getLabwareViewBox } from '@opentrons/shared-data'

import { labwareImages } from './labware-images'
import { getLabwareViewBox, labwareImages } from '@opentrons/shared-data'

import type { LabwareDefinition } from '@opentrons/shared-data'

Expand Down
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
import { fireEvent, screen } from '@testing-library/react'
import { beforeEach, describe, expect, it } from 'vitest'

import { labwareImages } from '@opentrons/shared-data'

import { renderWithProviders } from '/app/__testing-utils__'
import { mockDefinition } from '/app/redux/custom-labware/__fixtures__'

import { Gallery } from '../Gallery'
import { labwareImages } from '../labware-images'

import type { ComponentProps } from 'react'

Expand Down
Loading
Loading