-
Notifications
You must be signed in to change notification settings - Fork 187
refactor(app, labware-designer, labware-library, opentrons-ai-client, shared-data): Move all labware images to shared-data #19088
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
rclarke0
wants to merge
42
commits into
edge
Choose a base branch
from
relocate-labware-images
base: edge
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+759
−1,975
Draft
Changes from 17 commits
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
22f2e2c
creating new location for labware images
rclarke0 58cb304
move images into shared-data
rclarke0 2239c7d
removing duplicate svgs
rclarke0 7cae0a1
fix lint errors
rclarke0 60a88ae
revert deleted file
rclarke0 3a1a358
pipfile
rclarke0 2e5004e
Merge branch 'edge' into relocate-labware-images
rclarke0 90dacf2
fix lint error in abr-testing folder
rclarke0 660495e
fix prettier errors
rclarke0 61ff951
prettier fix 2
rclarke0 0708c8f
prettier fix
rclarke0 824c774
add readme file
rclarke0 aa08e71
removing additional labwareimages.ts
rclarke0 f7b5f52
add test
rclarke0 afe9921
lint fix
rclarke0 24048ba
lint fixes
rclarke0 a647008
fix lint
rclarke0 53f96fa
fixes ot2 calibration bus
rclarke0 1b41de8
changed labware-images.ts to use glob and updated test case to check …
rclarke0 f5d6d20
prettier
rclarke0 88bd96a
updating images
rclarke0 0821c00
draft images
rclarke0 0865e73
changing some images
rclarke0 dff9107
labware images
rclarke0 a1fc4b8
Merge branch 'edge' into relocate-labware-images
rclarke0 7722b82
fix test
rclarke0 7588294
eppendorf labware
rclarke0 01e8547
change to local import statement
rclarke0 6f9c6b4
prettier fixes on README.md
rclarke0 0f0b925
combined labware-images.ts with labware.ts and resized images
rclarke0 34fa366
Merge branch 'edge' into relocate-labware-images
rclarke0 f37c950
abr-testing lint and format fixing
rclarke0 6156767
Merge branch 'edge' into relocate-labware-images
rclarke0 7e21840
Merge branch 'edge' into relocate-labware-images
rclarke0 6eb793c
fix(abr-testing): rever abr-testing changes
rclarke0 c763f24
fix(abr-testing): revert protocol changes
rclarke0 c40464b
refactor(shared-data): Increase visibility for labware image tools sc…
rclarke0 fec7852
refactor(shared-data): remove pillow package dependency
rclarke0 3b338e0
feat(shared-data): Test for properly formatted images.
rclarke0 a7455d5
fix(shard-data): Image size change.
rclarke0 3ffc07b
fix hard coded directory
rclarke0 ffa6adb
Draft changes to image editor
rclarke0 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
Binary file not shown.
This file was deleted.
Oops, something went wrong.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
This file was deleted.
Oops, something went wrong.
Binary file removed
BIN
-48 KB
app/src/assets/images/labware/thermoscientificnunc_96_wellplate_1300ul.jpg
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,2 @@ | ||
export * from './getAllDefinitions' | ||
export * from './labwareImages' | ||
export * from './getAllDefs' |
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 2 additions & 1 deletion
3
app/src/organisms/Desktop/Labware/LabwareDetails/__tests__/Gallery.test.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need some way to convey which image is "primary"? Or at least make sure the images are sorted in a deliberate way such that
[0]
is always "primary"?You can imagine, like, a tip rack having a picture of the whole tip rack, and a separate picture of just a single tip. The prior behavior of this code was to show the whole tip rack, and we probably want to keep doing that. As-is, I don't think anything guarantees that we wouldn't accidentally show the single-tip picture.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It creates the list in alphabetical order so I don't think we need to
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed this to sort labwareImages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the images are alphabetically sorted, and the "primary" image is the first image in this alphabetical list, can you expand the README to explain this behavior? Maybe note that the "primary" image should always be named the
labware_load_name
and any other images should have secondary text appended to the name