Skip to content

feat(protocol-designer): remove warning for disposal volume #19090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: edge
Choose a base branch
from

Conversation

koji
Copy link
Contributor

@koji koji commented Jul 30, 2025

Overview

remove warning for disposal volume

close AUTH-1416

Test Plan and Hands on Testing

Changelog

Review requests

Risk assessment

low

@koji koji requested review from ncdiehl11 and jerader July 30, 2025 20:40
@koji koji marked this pull request as ready for review July 30, 2025 20:43
Copy link
Collaborator

@jerader jerader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait, i thought @ncdiehl addressed this already for some reason 😅

Copy link

codecov bot commented Jul 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 25.11%. Comparing base (2d58c37) to head (aee909e).
⚠️ Report is 8 commits behind head on edge.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #19090      +/-   ##
==========================================
+ Coverage   25.10%   25.11%   +0.01%     
==========================================
  Files        3371     3371              
  Lines      296325   296377      +52     
  Branches    31400    31420      +20     
==========================================
+ Hits        74394    74439      +45     
- Misses     221903   221910       +7     
  Partials       28       28              
Flag Coverage Δ
protocol-designer 18.91% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
protocol-designer/src/steplist/formLevel/index.ts 47.40% <100.00%> (-0.90%) ⬇️
...igner/src/steplist/formLevel/test/warnings.test.ts 88.93% <ø> (-0.26%) ⬇️

... and 8 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@koji
Copy link
Contributor Author

koji commented Jul 30, 2025

wait, i thought @ncdiehl addressed this already for some reason 😅

8.5.0 still has the warning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants