Skip to content

fix(protocol-designer): fix white-screen issue when editing an error step #19092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: edge
Choose a base branch
from

Conversation

koji
Copy link
Contributor

@koji koji commented Jul 31, 2025

Overview

fix white-screen issue when editing an error step

https://opentrons.slack.com/archives/C07E9T2NAQK/p1753914545991059?thread_ts=1753912648.387269&cid=C07E9T2NAQK

i think we need to update the entire error/warning catch system structure to resolve this or prevent removing a module if it is used by a step/steps.

close RQA-3994 partially

Test Plan and Hands on Testing

low

Changelog

Review requests

Risk assessment

…step

fix white-screen issue when editing an error step

close RQA-3994 partially
@koji koji requested review from jerader and ncdiehl11 and removed request for jerader July 31, 2025 14:52
Copy link

codecov bot commented Jul 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 24.45%. Comparing base (fc09053) to head (5982b12).
⚠️ Report is 7 commits behind head on edge.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #19092      +/-   ##
==========================================
- Coverage   24.45%   24.45%   -0.01%     
==========================================
  Files        3371     3371              
  Lines      296262   296280      +18     
  Branches    31417    31415       -2     
==========================================
+ Hits        72462    72466       +4     
- Misses     223773   223787      +14     
  Partials       27       27              
Flag Coverage Δ
protocol-designer 18.91% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../Designer/ProtocolSteps/Timeline/StepContainer.tsx 63.50% <100.00%> (+0.13%) ⬆️
...signer/ProtocolSteps/Timeline/StepOverflowMenu.tsx 72.85% <100.00%> (+0.59%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@koji koji marked this pull request as ready for review July 31, 2025 15:25
Copy link
Collaborator

@ncdiehl11 ncdiehl11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@koji
Copy link
Contributor Author

koji commented Aug 1, 2025

  • check 8.5.0 since this issue doesn't happen to 8.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants