Skip to content

feat(app, app-shell) : Create the first step of password protection for file access #19104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: edge
Choose a base branch
from

Conversation

alexjoel42
Copy link
Contributor

Overview

I was curious if I could build password protection on the Opentrons App for protocol files

Test Plan and Hands on Testing

  1. Make sure migrations work upgrading and downgrading
  2. Make sure that installing a new version of the app you can lock it

Changelog

  • Made a new databse
  • added knex for database reading and writing and bcrypt for securing passwords

Review requests

Non for now

Risk assessment

Medium/High. This is messing with a core user flow.
It's part of a three step process:

  1. Set up basic outline to remove in the UI
  2. Find some way to lock it in the back end too
  3. Make tests and whatnot to ensure that it works

…word protected lock of protocol. Next commit should be primarily app shel and building out back end work
…and a couple of packages like knex for database reading and writing and bcrypt for securing passwords
@alexjoel42
Copy link
Contributor Author

Think about options

Through app settings

  • Use /app-shell/src/config/migrate.ts
  • config.json (/users/name/library/application support/opentrons ) of the app. Because ultimately it's good to do this in app settings.
    Through protocol data base
  • What we have in this pr
    Through the protocol file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant