Skip to content

feat(protocol-designer): introduce byVolume curve builder prototype #19114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 12 commits into
base: edge
Choose a base branch
from

Conversation

ncdiehl11
Copy link
Collaborator

@ncdiehl11 ncdiehl11 commented Aug 4, 2025

Overview

This PR introduces and wires up new components and logic for viewing creating custom by-volume curves.

Test Plan and Hands on Testing

Changelog

Review requests

Risk assessment

Copy link

codecov bot commented Aug 7, 2025

Codecov Report

❌ Patch coverage is 18.22785% with 323 lines in your changes missing coverage. Please review.
✅ Project coverage is 24.86%. Comparing base (9f3fcfd) to head (801cecc).

Files with missing lines Patch % Lines
...StepTools/ByVolumeBuilderModal/ByVolumeBuilder.tsx 1.98% 99 Missing ⚠️
...ools/ByVolumeBuilderModal/ByVolumeBuilderModal.tsx 2.98% 65 Missing ⚠️
...ols/MoveLiquidTools/SecondStepsMoveLiquidTools.tsx 0.00% 56 Missing ⚠️
...pTools/ByVolumeBuilderModal/ByVolumeCalculator.tsx 3.50% 55 Missing ⚠️
...s/StepForm/StepTools/ByVolumeBuilderModal/utils.ts 7.69% 48 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #19114      +/-   ##
==========================================
- Coverage   24.87%   24.86%   -0.01%     
==========================================
  Files        3375     3382       +7     
  Lines      296767   297151     +384     
  Branches    31488    31495       +7     
==========================================
+ Hits        73817    73889      +72     
- Misses     222926   223238     +312     
  Partials       24       24              
Flag Coverage Δ
protocol-designer 18.92% <18.22%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...tocol-designer/src/assets/localization/en/index.ts 96.00% <100.00%> (+0.16%) ⬆️
protocol-designer/src/feature-flags/reducers.ts 56.06% <100.00%> (+1.37%) ⬆️
protocol-designer/src/feature-flags/selectors.ts 83.82% <100.00%> (+1.01%) ⬆️
protocol-designer/src/feature-flags/types.ts 95.83% <100.00%> (+0.08%) ⬆️
...epForm/StepTools/ByVolumeBuilderModal/constants.ts 100.00% <100.00%> (ø)
...s/StepForm/StepTools/ByVolumeBuilderModal/types.ts 100.00% <100.00%> (ø)
protocol-designer/typings/react-plotly.d.ts 100.00% <100.00%> (ø)
...s/StepForm/StepTools/ByVolumeBuilderModal/utils.ts 7.69% <7.69%> (ø)
...pTools/ByVolumeBuilderModal/ByVolumeCalculator.tsx 3.50% <3.50%> (ø)
...ols/MoveLiquidTools/SecondStepsMoveLiquidTools.tsx 0.48% <0.00%> (-0.04%) ⬇️
... and 2 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ncdiehl11 ncdiehl11 self-assigned this Aug 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant