Skip to content

fix(app): reset RTP capture if analysis changes #19134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: edge
Choose a base branch
from

Conversation

sfoster1
Copy link
Member

@sfoster1 sfoster1 commented Aug 6, 2025

The ChooseRobotToRunProtocolSlideout needed to reset its react state that captures the RTP value overrides, since it doesn't get unmounted if you alter the protocol and reanalyze it. Sad.

Closes RQA-4496

The ChooseRobotToRunProtocolSlideout needed to reset its react state
that captures the RTP value overrides, since it doesn't get unmounted if
you alter the protocol and reanalyze it. Sad.

Closes RQA-4496
@sfoster1 sfoster1 requested a review from skowalski08 August 6, 2025 15:45
Copy link

codecov bot commented Aug 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.22%. Comparing base (fc09053) to head (af7db2f).
⚠️ Report is 43 commits behind head on edge.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             edge   #19134       +/-   ##
===========================================
+ Coverage   24.45%   55.22%   +30.76%     
===========================================
  Files        3371     3371               
  Lines      296262   296304       +42     
  Branches    31417    37712     +6295     
===========================================
+ Hits        72462   163628    +91166     
+ Misses     223773   132407    -91366     
- Partials       27      269      +242     
Flag Coverage Δ
app 47.34% <100.00%> (+45.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...Desktop/ChooseRobotToRunProtocolSlideout/index.tsx 65.17% <100.00%> (+65.17%) ⬆️

... and 1712 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sfoster1 sfoster1 requested a review from smb2268 August 6, 2025 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant