Skip to content

fix(app): allow door to open when releasing latch and home gantry axes when launching ER for stacker #19153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: chore_release-8.6.0
Choose a base branch
from

Conversation

ahiuchingau
Copy link
Contributor

Overview

We must allow the door to open when releasing the labware latch so user can manually catch the labware. Also, we want to make sure the instruments are out of the way when we launch stacker-related ER, so let's home everything except plungers for the stacker error kinds.

Copy link

codecov bot commented Aug 7, 2025

Codecov Report

❌ Patch coverage is 0% with 44 lines in your changes missing coverage. Please review.
✅ Project coverage is 24.01%. Comparing base (3635cb6) to head (3235322).
⚠️ Report is 1 commits behind head on chore_release-8.6.0.

Files with missing lines Patch % Lines
app/src/organisms/ErrorRecoveryFlows/constants.ts 0.00% 13 Missing ⚠️
...rc/organisms/ErrorRecoveryFlows/RecoverySplash.tsx 0.00% 11 Missing ⚠️
...rganisms/ErrorRecoveryFlows/RecoveryInProgress.tsx 0.00% 7 Missing ⚠️
.../ErrorRecoveryFlows/hooks/useRouteUpdateActions.ts 0.00% 5 Missing ⚠️
.../organisms/ErrorRecoveryFlows/RecoveryDoorOpen.tsx 0.00% 3 Missing ⚠️
...ErrorRecoveryFlows/shared/StackerReengageLatch.tsx 0.00% 3 Missing ⚠️
...ganisms/ErrorRecoveryFlows/ErrorRecoveryWizard.tsx 0.00% 1 Missing ⚠️
...nisms/ErrorRecoveryFlows/shared/ReleaseLabware.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##           chore_release-8.6.0   #19153      +/-   ##
=======================================================
- Coverage                24.01%   24.01%   -0.01%     
=======================================================
  Files                     3377     3377              
  Lines                   296971   296972       +1     
  Branches                 31523    31520       -3     
=======================================================
  Hits                     71304    71304              
- Misses                  225649   225650       +1     
  Partials                    18       18              
Flag Coverage Δ
protocol-designer 18.92% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
app/src/organisms/ErrorRecoveryFlows/types.ts 100.00% <ø> (ø)
...ganisms/ErrorRecoveryFlows/ErrorRecoveryWizard.tsx 0.00% <0.00%> (ø)
...nisms/ErrorRecoveryFlows/shared/ReleaseLabware.tsx 0.00% <0.00%> (ø)
.../organisms/ErrorRecoveryFlows/RecoveryDoorOpen.tsx 0.00% <0.00%> (ø)
...ErrorRecoveryFlows/shared/StackerReengageLatch.tsx 0.00% <0.00%> (ø)
.../ErrorRecoveryFlows/hooks/useRouteUpdateActions.ts 0.00% <0.00%> (ø)
...rganisms/ErrorRecoveryFlows/RecoveryInProgress.tsx 0.00% <0.00%> (ø)
...rc/organisms/ErrorRecoveryFlows/RecoverySplash.tsx 0.00% <0.00%> (ø)
app/src/organisms/ErrorRecoveryFlows/constants.ts 0.00% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, cool!

Copy link
Contributor

@TamarZanzouri TamarZanzouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@vegano1 vegano1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense!

@ahiuchingau ahiuchingau changed the base branch from edge to chore_release-8.6.0 August 8, 2025 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants