-
Notifications
You must be signed in to change notification settings - Fork 186
fix(app): allow door to open when releasing latch and home gantry axes when launching ER for stacker #19153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: chore_release-8.6.0
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## chore_release-8.6.0 #19153 +/- ##
=======================================================
- Coverage 24.01% 24.01% -0.01%
=======================================================
Files 3377 3377
Lines 296971 296972 +1
Branches 31523 31520 -3
=======================================================
Hits 71304 71304
- Misses 225649 225650 +1
Partials 18 18
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, cool!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes sense!
Overview
We must allow the door to open when releasing the labware latch so user can manually catch the labware. Also, we want to make sure the instruments are out of the way when we launch stacker-related ER, so let's home everything except plungers for the stacker error kinds.