Skip to content

Conversation

koji
Copy link
Contributor

@koji koji commented Aug 7, 2025

Overview

fix tip drop location display in overview tab

close RQA-4504

Test Plan and Hands on Testing

Changelog

Review requests

low

Risk assessment

fix tip drop location display in overview tab

clse RQA-4504
@koji koji requested a review from ncdiehl11 August 7, 2025 18:37
@koji koji marked this pull request as ready for review August 7, 2025 18:37
Copy link
Collaborator

@ncdiehl11 ncdiehl11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested on dev ODD, looks good

Copy link

codecov bot commented Aug 8, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 23.99%. Comparing base (2da4c80) to head (78e83d1).
⚠️ Report is 3 commits behind head on edge.

Files with missing lines Patch % Lines
.../QuickTransferFlow/utils/getInitialSummaryState.ts 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #19157      +/-   ##
==========================================
- Coverage   24.00%   23.99%   -0.02%     
==========================================
  Files        3377     3377              
  Lines      296977   296857     -120     
  Branches    31539    31524      -15     
==========================================
- Hits        71301    71240      -61     
+ Misses     225658   225598      -60     
- Partials       18       19       +1     
Flag Coverage Δ
app 2.07% <0.00%> (-0.02%) ⬇️
opentrons-ai-client 3.20% <0.00%> (+0.08%) ⬆️
protocol-designer 18.92% <0.00%> (-0.01%) ⬇️
step-generation 5.37% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../QuickTransferFlow/utils/getInitialSummaryState.ts 0.00% <0.00%> (ø)

... and 20 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@koji koji changed the base branch from edge to chore_release-8.6.0 August 8, 2025 22:17
@koji koji requested review from a team as code owners August 8, 2025 22:17
@koji koji requested review from jerader and removed request for a team August 8, 2025 22:17
@koji koji changed the base branch from chore_release-8.6.0 to edge August 8, 2025 22:17
@koji
Copy link
Contributor Author

koji commented Aug 8, 2025

  • need cherry-pick this for choare_release-8.6.0

@koji koji merged commit 0d1db4c into edge Aug 8, 2025
47 of 48 checks passed
@koji koji deleted the fix_RQA-4504 branch August 8, 2025 22:26
neo-jesse pushed a commit that referenced this pull request Aug 19, 2025
* fix(app): fix tip drop location display in overview tab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants