fix(app): allow setup with no pipette #19160
Open
+434
−71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfoster1
changed the title
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## chore_release-8.6.0 #19160 +/- ##
=======================================================
+ Coverage 24.00% 24.19% +0.18%
=======================================================
Files 3377 3377
Lines 296968 297021 +53
Branches 31523 31541 +18
=======================================================
+ Hits 71301 71870 +569
+ Misses 225649 225128 -521
- Partials 18 23 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
smb2268
reviewed
Aug 8, 2025
| export function useModuleAttachedToast( | ||
| launchModuleSetupCallback: () => void | ||
| ): void { | ||
| const newModules = useGetNewModules() | ||
| const currentlySetuppableModules = useGetModulesNeedingSetupThatCanCurrentlyBeSetUp() |
smb2268
reviewed
Aug 8, 2025
| // allNeedingSetup is a superset of allSetupable | ||
| const hasUnsetupabbleModules = allNeedingSetup.length > allSetupable.length | ||
| const isSingleModule = newModules.length === 1 && !hasUnsetupabbleModules | ||
| const shortCircuitFlow = attachedModuleOnLaunch != null || isSingleModule |
There was a problem hiding this comment.
Can you add another comment explaining this variable a bit?
smb2268
approved these changes
Aug 8, 2025
We want to allow module setup flows when there aren't pipettes attached, if the module can be setup without pipettes. Which is some of them, some of the time, from 3 different places. "Closes" RQA-4481
This is a little nicer. Split up the getNewModules code to separate modules between whether or not they need a pipette to be set up, so we can prompt for modules that can be set up immediately.
Sorry! It's kind of ugly but needed, right now
This way you won't be confused if you only see your stackers
sfoster1
force-pushed
the
rqa-4481-oh-god
branch
from
0688d87 to
0479406
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to allow module setup flows when there aren't pipettes attached, if the module can be setup without pipettes. Which is some of them, some of the time, from 3 different places.
Closes RQA-4481
The new behavior applies to stackers and to absorbance readers, since neither requires a pipette for setup.
The new behavior should be: