fix(app): Ensure stacker display location is 3+4, shuttle labware slot is 4

[smb2268]

Fix https://opentrons.atlassian.net/browse/RQA-4384, RQA-4395, RQA-4369, RQA-4429

Overview

This PR updates stacker display location in protocol setup hardware, protocol details, and intervention and error recovery modals

Test Plan and Hands on Testing

• Test error recovery flows to look at previous and current labware locations for stacker
• Look at protocol details list for stacker locations
• Look at protocol setup hardware section at stacker locations
• Look at manual move labware from shuttle modal

Changelog

Create ModuleDeckLabel function to unify logic
Refactor intervention info to use existing utility for grabbing labware locations
Update various display locations to use new function

Review requests

This is far reaching and Alise and I both worked on it! As much testing as possible would be great

Risk assessment

Medium, pretty wide surface but just touches location names

[codecov]

Codecov Report

❌ Patch coverage is 5.12821% with 148 lines in your changes missing coverage. Please review.
✅ Project coverage is 24.66%. Comparing base (95b9d6e) to head (8588ce1).
⚠️ Report is 4 commits behind head on edge.

Files with missing lines	Patch %	Lines
...terventionModal/MoveLabwareInterventionContent.tsx	0.00%	30 Missing ⚠️
...mandTextString/utils/getLabwareDisplayLocation.tsx	0.00%	24 Missing ⚠️
shared-data/js/helpers/getModuleDeckLabel.ts	13.04%	20 Missing ⚠️
.../useCommandTextString/utils/getLabwareLocation.tsx	0.00%	19 Missing ⚠️
...ommandTextString/utils/getModuleDisplayLocation.ts	11.11%	8 Missing ⚠️
...rrorRecoveryFlows/shared/LeftColumnLabwareInfo.tsx	0.00%	6 Missing ⚠️
app/src/pages/ODD/ProtocolDetails/Hardware.tsx	0.00%	6 Missing ⚠️
...pp/src/pages/ODD/QuickTransferDetails/Hardware.tsx	0.00%	6 Missing ⚠️
...TextString/utils/commandText/getLoadCommandText.ts	0.00%	6 Missing ⚠️
...rotocolRun/SetupModuleAndDeck/SetupModulesList.tsx	0.00%	5 Missing ⚠️
... and 6 more

Additional details and impacted files

@@            Coverage Diff             @@
##             edge   #19167      +/-   ##
==========================================
+ Coverage   24.00%   24.66%   +0.65%     
==========================================
  Files        3377     3377              
  Lines      296968   297037      +69     
  Branches    31523    31758     +235     
==========================================
+ Hits        71301    73262    +1961     
+ Misses     225649   223750    -1899     
- Partials       18       25       +7     

Flag	Coverage Δ
protocol-designer	18.92% <5.12%> (-0.01%)	⬇️
shared-data	2.82% <1.96%> (-69.95%)	⬇️
step-generation	5.37% <1.92%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...sources/runs/useModuleRenderInfoForProtocolById.ts	0.00% <ø> (ø)
components/src/hardware-sim/Deck/SlotLabels.tsx	83.00% <100.00%> (+0.52%)	⬆️
shared-data/js/helpers/index.ts	67.46% <ø> (+10.12%)	⬆️
.../ErrorRecoveryFlows/shared/TwoColLwInfoAndDeck.tsx	0.00% <0.00%> (ø)
.../ErrorRecoveryFlows/shared/StackerHopperLwInfo.tsx	0.00% <0.00%> (ø)
...ErrorRecoveryFlows/shared/StackerShuttleLwInfo.tsx	0.00% <0.00%> (ø)
...ktop/ProtocolDetails/RobotConfigurationDetails.tsx	0.00% <0.00%> (ø)
...up/ProtocolSetupModulesAndDeck/ModuleTableItem.tsx	0.00% <0.00%> (ø)
...rotocolRun/SetupModuleAndDeck/SetupModulesList.tsx	0.00% <0.00%> (ø)
.../Desktop/Protocols/ProtocolPreview/SlotDetails.tsx	0.00% <0.00%> (ø)
... and 9 more

... and 49 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[TamarZanzouri]

LGTM! nice work!

[ahiuchingau]

Thank you so much!!

[ahiuchingau]

Oh yes yes yes