Skip to content

Run tests using GitHub Actions #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 19, 2025
Merged

Run tests using GitHub Actions #2

merged 1 commit into from
Mar 19, 2025

Conversation

@Farjaad
Copy link
Collaborator

@Farjaad Farjaad commented Mar 19, 2025

No description provided.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Farjaad Farjaad force-pushed the run-tests branch 10 times, most recently from 25732e1 to c6d7b82 Compare March 19, 2025 17:58
Farjaad
Farjaad commented Mar 19, 2025
View reviewed changes
spec/support/models.rb
end

class Block < ApplicationRecord
class Block < ActiveRecord::Base
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was getting an uninitialized constant for ApplicationRecord so I changed this to match what all the other models do

Copy link
Collaborator

@derek-etherton-opslevel derek-etherton-opslevel Mar 19, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ope good call, the version I forked back to is targeting an older Ruby version than the PR I copied from

Farjaad
Farjaad commented Mar 19, 2025
View reviewed changes
spec/support/schema.rb

create_table "uuid_tags", :id => false do |t|
t.string "uuid", :unique => true
t.string "uuid"
Copy link
Collaborator Author

@Farjaad Farjaad Mar 19, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why I needed to change this (or why it was valid in the first place)

@derek-etherton-opslevel
Copy link
Collaborator

derek-etherton-opslevel commented Mar 19, 2025 •
edited
Loading

tests be running... looks awesome, thank you!
Sorry for yankin them out in the first place

@Farjaad Farjaad merged commit 4a81efa into master Mar 19, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@derek-etherton-opslevel derek-etherton-opslevel derek-etherton-opslevel approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Farjaad @CLAassistant @derek-etherton-opslevel @farjaad-opslevel