Skip to content
Open
Changes from 1 commit
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
eaa89ee
loose attempt at using the much more performant REST interface for re…
avermeil Feb 9, 2024
abe39ff
convert more functions to REST
avermeil Feb 13, 2024
ea18c81
fix for summary row in multi page report calls
avermeil Feb 13, 2024
17179ea
add support for max_reporting_rows
avermeil Feb 16, 2024
dbcd84a
attempt to parse deep messages (not yet working)
avermeil Mar 1, 2024
abf3d59
Merge branch 'master' into rest-reports
avermeil Mar 1, 2024
dc857a5
use protobuf's lookup fn to build path-to-fieldType object for parsing
avermeil Mar 3, 2024
dea642a
adjust tests
avermeil Mar 7, 2024
04620df
minor cleanup
avermeil Mar 7, 2024
639d1b0
fix for enums not in mega
avermeil Mar 19, 2024
42479c0
minor cleanup
avermeil Mar 20, 2024
4fa4623
remove logging
avermeil Mar 20, 2024
ab68954
better handling of unknown errors
avermeil Mar 21, 2024
18bba8c
remove redundant auth in REST headers
avermeil Mar 21, 2024
e8a3074
fix issue with totalResultsCount
avermeil Mar 21, 2024
d9ca0ba
fix tests
avermeil Mar 21, 2024
87007da
Merge branch 'master' into rest-reports
avermeil Sep 27, 2024
e68425f
run yarn compile
avermeil Sep 27, 2024
a1cb776
Merge branch 'v19' into rest-reports
avermeil Mar 10, 2025
dce2c55
remove TODO
avermeil Mar 10, 2025
e1a48ae
minor adjustments to reflect new search_settings
avermeil Mar 10, 2025
1b0407e
Test fixes
FidelElie Mar 12, 2025
ebe68f0
Merge branch 'master' into rest-reports
FidelElie Mar 12, 2025
90db605
Merge branch 'master' into rest-reports
FidelElie Mar 12, 2025
2fea840
Fix error for omitted return_total_results field
FidelElie Mar 12, 2025
9e4cc97
Add back return_total_results_count request option
FidelElie Mar 12, 2025
f61b500
fix search_settings example
Lewis-Clayton Mar 12, 2025
cd69e5a
fix for .reportCount()
avermeil Mar 17, 2025
1f28ffe
escape query constraints
Lewis-Clayton Apr 25, 2025
e86164b
better handling of undefined results from stream
avermeil Apr 25, 2025
8daa3c7
bump version
avermeil Apr 25, 2025
8940c99
Comply with tests
Lewis-Clayton Apr 25, 2025
25247eb
Merge pull request #511 from Opteo/escaping-query-constraints
Lewis-Clayton Apr 29, 2025
6721282
Bump Version
Lewis-Clayton Apr 29, 2025
9be5bc0
v20 update
Lewis-Clayton Jun 5, 2025
97922b9
prettified
Lewis-Clayton Jun 5, 2025
9031b45
merge v20 in to rest-reports
Lewis-Clayton Jun 6, 2025
d470975
re-yarn
Lewis-Clayton Jun 6, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/customer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ export class Customer extends ServiceFactory {
): Promise<number | undefined> {
const { gaqlQuery, requestOptions } = buildQuery({ ...options, limit: 1 }); // must get at least one row
// We do not allow this field in reportOptions, however it is still a valid request option
requestOptions.search_settings = { return_total_results_count: true };
requestOptions.search_settings = { return_summary_row: true };
const useHooks = false; // to avoid cacheing conflicts
const { totalResultsCount } = await this.querier(
gaqlQuery,
Expand Down Expand Up @@ -226,11 +226,11 @@ export class Customer extends ServiceFactory {
gaqlQuery: string,
requestOptions: Readonly<
RequestOptions & {
search_settings?: {
// We do not allow return_total_results_count in reportOptions, however it is still a valid request option
return_total_results_count?: boolean;
return_summary_row?: boolean;
};
// We do not allow return_total_results_count in reportOptions, however it is still a valid request option
search_settings?: Pick<
services.ISearchSettings,
"return_summary_row" | "return_total_results_count"
>;
}
>
): Promise<{
Expand Down
Loading