Fix memory ordering race condition in MotelyPaths initialization

[Copilot]

The MotelyPaths static class had a memory ordering race condition: only _contentRoot and _isInitialized were volatile, but the override path fields were not. Threads could observe _isInitialized = true while still seeing uninitialized values for _jamlFiltersOverride, _seedSourcesOverride, and _searchResultsOverride due to CPU cache coherency delays.

Changes

• Made all static fields in MotelyPaths volatile to ensure proper memory ordering

private static volatile string _contentRoot = Directory.GetCurrentDirectory();
private static volatile string? _jamlFiltersOverride;      // now volatile
private static volatile string? _seedSourcesOverride;      // now volatile  
private static volatile string? _searchResultsOverride;    // now volatile
private static volatile bool _isInitialized = false;

This guarantees that when a thread observes _isInitialized = true, it will also observe the correct initialized values for all override paths written during Initialize().

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

[Copilot]

Pull request overview

This PR addresses a memory ordering race condition in the MotelyPaths static class by adding the volatile keyword to three static fields that store path override configurations. The fix ensures proper memory visibility when these fields are written during initialization and subsequently read by concurrent threads accessing path properties.

Changes:

• Added volatile modifier to _jamlFiltersOverride, _seedSourcesOverride, and _searchResultsOverride static fields to ensure memory ordering consistency

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The MotelyPaths class lacks test coverage for its initialization and thread-safety behavior. Consider adding tests to verify that the volatile fields are properly initialized and that concurrent access to path properties after initialization works correctly. This is especially important given that this PR addresses a memory ordering race condition.