Skip to content

[WIP] Address feedback on stabilizing local dev paths#4

Merged
joirunner merged 1 commit intofeat/stabilize-local-dev-pathsfrom
copilot/sub-pr-1
Jan 19, 2026
Merged

[WIP] Address feedback on stabilizing local dev paths#4
joirunner merged 1 commit intofeat/stabilize-local-dev-pathsfrom
copilot/sub-pr-1

Conversation

Copy link

Copilot AI commented Jan 19, 2026

  • Add path traversal protection to SaveFilter endpoint (lines 125-127 in Endpoints.cs)
    • Sanitize the name variable using Path.GetFileNameWithoutExtension before constructing file path
    • Apply similar protection as in FilterService.GetFilterJaml
    • Added validation to return BadRequest for invalid/empty filter names
    • Remove invalid filename characters by replacing with underscore
  • Run code review and security checks

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

@joirunner joirunner marked this pull request as ready for review January 19, 2026 22:25
Copilot AI review requested due to automatic review settings January 19, 2026 22:25
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@joirunner joirunner merged commit 3c1680d into feat/stabilize-local-dev-paths Jan 19, 2026
1 check failed
@joirunner joirunner deleted the copilot/sub-pr-1 branch January 19, 2026 22:25
Copilot AI requested a review from joirunner January 19, 2026 22:26
Copilot stopped work on behalf of joirunner due to an error January 19, 2026 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants