Conversation
jan-kozak-oc2
previously approved these changes
Jan 27, 2026
jacekniezgoda-oc
previously approved these changes
Jan 27, 2026
There was a problem hiding this comment.
Pull request overview
This PR refines the Process Administration UI interactions by switching several node/variable/assignee operations to AJAX-style fetch calls and changing corresponding controller actions to return JSON success responses.
Changes:
- Added a shared UI error container and a new i18n message for generic server communication failures.
- Refactored variable/node ordering and delete operations to use
fetch+ JSON responses (and introduced common delete handling in the nodes list). - Updated multiple controller actions to enforce HTTP methods and return JSON
{success: ...}payloads instead of redirects.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 19 comments.
Show a summary per file
| File | Description |
|---|---|
| grails-app/views/processNodeDef/nodeForm.gsp | Adds an error container intended for AJAX error display. |
| grails-app/views/processDef/editProcess.gsp | Adds an error container intended for AJAX error display. |
| grails-app/views/processDef/_variablesList.gsp | Moves variable reorder/delete to fetch and updates DOM identifiers/classes. |
| grails-app/views/processDef/_nodesList.gsp | Moves node reorder/delete + transition delete to fetch and adds shared delete helper. |
| grails-app/views/common/_assigneesEditor.gsp | Migrates assignee add/delete to fetch and centralizes request handling. |
| grails-app/i18n/common.properties | Adds plugin.grailsflow.internalError message. |
| grails-app/controllers/ProcessVarDefController.groovy | Adds allowedMethods + JSON responses for delete/reorder endpoints. |
| grails-app/controllers/ProcessTransitionDefController.groovy | Adds allowedMethods + JSON response endpoint for transition delete (renamed action). |
| grails-app/controllers/ProcessNodeDefController.groovy | Adds allowedMethods + JSON responses for delete/reorder/assignee delete endpoints. |
| application.properties | Bumps snapshot version with ticket suffix. |
| GrailsflowGrailsPlugin.groovy | Aligns plugin version with ticket-suffixed snapshot. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
6cbbb54
WojciechStrzelinski-oc
requested changes
Jan 29, 2026
Contributor
WojciechStrzelinski-oc
left a comment
There was a problem hiding this comment.
don't use such deep if statements
97e73db to
7e6183a
Compare
…ndpoint-refinement' [ci skip]
7e6183a to
8a74113
Compare
jan-kozak-oc2
requested changes
Feb 4, 2026
jan-kozak-oc2
approved these changes
Feb 4, 2026
jacekniezgoda-oc
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://opuscapita.atlassian.net/browse/EPROC-22810