Skip to content

[OUDS] Add text color utilities to the Colors tokens PR #2830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
louismaximepiton merged 2 commits into from
Jan 20, 2025
Merged

[OUDS] Add text color utilities to the Colors tokens PR #2830

louismaximepiton merged 2 commits into from
Jan 20, 2025

Conversation

@louismaximepiton
Copy link
Member

@louismaximepiton louismaximepiton commented Dec 27, 2024 •
edited
Loading

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

NA

Description

Remaining tasks and questions

⚠️ Questions:

  • Do we keep colored links aligned with our text colors or not ?
  • Do we keep the dark mode for colored links (coming from Boosted legacy) ?
  • Do we keep all the utilities or do we keep only a few of them ?

Tasks:

Done list

The following was done in the PR:

  • Changed all the .text- color occurrences in the documentation
  • Introduced all the text color utilities and the corresponding documentation
  • Changed all the color properties in the Scss
  • Minor adapted the Scss variables
  • Introduced the colored links and the corresponding documentation
  • Tweaked a bit the callouts in the documentation
  • Uncommented some links in the doc
  • Added some new SVGs
  • Added text colors tests

To be done after the PR is merged

  • Uncomment things when Links are defined.
  • Uncomment things when Link utilities will be developed.

Motivation & Context

Types of change

  • New feature (non-breaking change which adds functionality)

Live previews

@louismaximepiton louismaximepiton added 📖 documentation Improvements or additions to documentation css labels Dec 27, 2024
@louismaximepiton louismaximepiton added this to the OUDS milestone Dec 27, 2024
@louismaximepiton louismaximepiton force-pushed the ouds/main-lmp-tokens-colors-border-utilities branch from 10b3d2a to 741f161 Compare December 30, 2024 08:31
@louismaximepiton louismaximepiton force-pushed the ouds/main-lmp-tokens-colors-text-utilities branch from 2ca8c15 to d44a18d Compare December 30, 2024 08:34
@louismaximepiton louismaximepiton changed the base branch from ouds/main-lmp-tokens-colors-border-utilities to ouds/main-lmp-tokens-colors-bg-utilities December 30, 2024 08:35
@louismaximepiton louismaximepiton force-pushed the ouds/main-lmp-tokens-colors-text-utilities branch 2 times, most recently from e0ad436 to b3965bc Compare January 3, 2025 13:26
Base automatically changed from ouds/main-lmp-tokens-colors-bg-utilities to ouds/main-lmp-tokens-colors January 6, 2025 10:19
@louismaximepiton louismaximepiton force-pushed the ouds/main-lmp-tokens-colors-text-utilities branch from b3965bc to 2c8b907 Compare January 6, 2025 15:45
@netlify
Copy link

netlify bot commented Jan 6, 2025 •
edited
Loading

✅ Deploy Preview for boosted ready!

Name Link
🔨 Latest commit f5fae42
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/678e1ca2b5ae4600081d8526
😎 Deploy Preview https://deploy-preview-2830--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@louismaximepiton louismaximepiton force-pushed the ouds/main-lmp-tokens-colors-text-utilities branch from 2c8b907 to a11c9b3 Compare January 6, 2025 15:54
@louismaximepiton louismaximepiton marked this pull request as ready for review January 6, 2025 16:06
@louismaximepiton louismaximepiton force-pushed the ouds/main-lmp-tokens-colors-text-utilities branch 6 times, most recently from 77424c7 to da1f218 Compare January 9, 2025 09:46
vprothais
vprothais reviewed Jan 15, 2025
View reviewed changes
vprothais
vprothais reviewed Jan 16, 2025
View reviewed changes
vprothais
vprothais reviewed Jan 17, 2025
View reviewed changes
Copy link
Collaborator

@vprothais vprothais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I've reviewed all files at last !

@louismaximepiton louismaximepiton force-pushed the ouds/main-lmp-tokens-colors-text-utilities branch from 664b27f to f5fae42 Compare January 20, 2025 09:51
@louismaximepiton louismaximepiton merged commit d3e7de0 into ouds/main-lmp-tokens-colors Jan 20, 2025
14 of 15 checks passed
@louismaximepiton louismaximepiton deleted the ouds/main-lmp-tokens-colors-text-utilities branch January 20, 2025 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vprothais vprothais vprothais approved these changes

Assignees

No one assigned

Labels

css 📖 documentation Improvements or additions to documentation

Projects

None yet

Milestone

OUDS v1

Development

Successfully merging this pull request may close these issues.

2 participants

@louismaximepiton @vprothais