Skip to content

[OUDS] Add the Bootstrap compatibilities in the doc and the code#2833

Merged
louismaximepiton merged 3 commits intoouds/main-lmp-tokens-colorsfrom
ouds/main-lmp-tokens-colors-bootstrap-compatibility
Jan 27, 2025
Merged

[OUDS] Add the Bootstrap compatibilities in the doc and the code#2833
louismaximepiton merged 3 commits intoouds/main-lmp-tokens-colorsfrom
ouds/main-lmp-tokens-colors-bootstrap-compatibility

Conversation

@louismaximepiton
Copy link
Member

@louismaximepiton louismaximepiton commented Jan 8, 2025

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

NA

Description

Remaining tasks and questions

⚠️ Questions:

  • .

Tasks:

Done list

The following was done in the PR:

  • Removed all the TODO LM occurrences by solving them or postponing for future us.
  • Added some missing OUDS mod
  • Removed entirely _colored-links.scss
  • Rewrite all Scss maps for Bootstrap compatibility with colors that we determined alltogether
  • Use correct CSS variables when they exist
  • Add all CSS variables related to colors inside Bootstrap compatibility
  • Adapted all the utilities in order to be more close to what should be rendered
  • Removed border-opacity, text-opacity and bg-opacity
  • Finished to adapt the Bootstrap variables to be sure that we have the right variables and the good rendering
  • Tweaked a bit the colored bgs to be inside Bootstrap compatibility and use the good colors
  • Adapted the CSS tests
  • Changed all the Bootstrap color CSS variables by the OUDS ones
  • Changed the shadows utilities
  • Added floating labels docs
  • Added all the missing documentation about how our color utilities are built
  • Added and checked all the bootstrap compatibility
  • Adapted our shortcodes

To be done after the PR is merged

  • Check for all the Scss diff, and check that there is no missing OUDS mod

Motivation & Context

Types of change

  • New feature (non-breaking change which adds functionality)

Live previews

@louismaximepiton louismaximepiton added 📖 documentation Improvements or additions to documentation css labels Jan 8, 2025
@louismaximepiton louismaximepiton added this to the OUDS milestone Jan 8, 2025
@louismaximepiton louismaximepiton force-pushed the ouds/main-lmp-tokens-colors-bootstrap-compatibility branch from 2458723 to c62291e Compare January 9, 2025 09:42
@louismaximepiton louismaximepiton force-pushed the ouds/main-lmp-tokens-colors-text-bg-helpers branch from 98f2509 to 6a2b3d5 Compare January 9, 2025 09:47
@louismaximepiton louismaximepiton force-pushed the ouds/main-lmp-tokens-colors-bootstrap-compatibility branch 5 times, most recently from 75bb0fc to 2120289 Compare January 15, 2025 14:26
Base automatically changed from ouds/main-lmp-tokens-colors-text-bg-helpers to ouds/main-lmp-tokens-colors-text-utilities January 17, 2025 10:52
@louismaximepiton louismaximepiton force-pushed the ouds/main-lmp-tokens-colors-text-utilities branch from 664b27f to f5fae42 Compare January 20, 2025 09:51
@louismaximepiton louismaximepiton force-pushed the ouds/main-lmp-tokens-colors-bootstrap-compatibility branch from 2120289 to c1477b0 Compare January 20, 2025 09:54
Base automatically changed from ouds/main-lmp-tokens-colors-text-utilities to ouds/main-lmp-tokens-colors January 20, 2025 10:16
@louismaximepiton louismaximepiton force-pushed the ouds/main-lmp-tokens-colors-bootstrap-compatibility branch from c1477b0 to 1cf8b84 Compare January 20, 2025 10:25
@netlify
Copy link

netlify bot commented Jan 20, 2025

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit 5d4a714
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/67979edade2fbe0008711b40
😎 Deploy Preview https://deploy-preview-2833--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@louismaximepiton louismaximepiton merged commit 6a559b8 into ouds/main-lmp-tokens-colors Jan 27, 2025
12 checks passed
@louismaximepiton louismaximepiton deleted the ouds/main-lmp-tokens-colors-bootstrap-compatibility branch January 27, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

css 📖 documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants