feat(component): Add Checkbox component#2874
Merged
Conversation
louismaximepiton
added
⚛️ component
📖 documentation
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This comment was marked as outdated.
This comment was marked as outdated.
louismaximepiton
force-pushed
the
ouds/main-lmp-checkbox-components
branch
3 times, most recently
from
c8f5e39 to
4a2ec0a
Compare
louismaximepiton
force-pushed
the
ouds/main-lmp-checkbox-components
branch
from
4a2ec0a to
74c8be4
Compare
MaxLardenois
force-pushed
the
ouds/main-lmp-checkbox-components
branch
from
df81b08 to
f6b4166
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new Checkbox component while updating and migrating related documentation and assets, along with adjustments in JavaScript to support the new component structure. Key changes include:
- Addition of the Checkbox component with multiple variants and examples.
- Updates to migration guides and sidebar configuration to reflect the new component.
- Adjustments in JavaScript code (tac.js) to target the new checkbox classes.
Reviewed Changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| site/content/docs/0.2/forms/overview.md | Updates the page description and adds an Accessibility section. |
| site/content/docs/0.2/forms/checkbox.md | Introduces the Checkbox component with various usage examples. |
| site/content/docs/0.2/migration-from-boosted.md | Updates migration instructions for checkboxes and related variables. |
| site/assets/js/tac.js | Updates selectors and markup to integrate the new Checkbox component in the consent UI. |
| site/content/docs/0.2/migration.md | Updates migration notes for Checkbox and other components. |
| site/content/docs/0.2/getting-started/introduction.md | Updates reference link for checkbox guidelines. |
| site/data/sidebar.yml | Updates sidebar entries to include the new Checkbox documentation. |
| site/content/docs/0.2/forms/checks-radios.md | Removes the deprecated Checks and Radios page. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…utualize code into control item
hannahiss
requested changes
Mar 19, 2025
Member
hannahiss
left a comment
hannahiss
left a comment
There was a problem hiding this comment.
Some documentation comments and request changes...
Maybe a design issue on the group, when having a long label? Not sure...
…ize on checked :hover :focus etc.
…xample for invalid
vprothais
requested changes
Mar 28, 2025
vprothais
requested changes
Mar 28, 2025
vprothais
approved these changes
Mar 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: Please transform
- [ ]into- (NA)in the description when things are not applicableRelated issues
#2781
Description
Remaining tasks and questions
Questions:
forms/overviewpage andforms/layoutas well ? Customize part as well -> No, let's wait for text input to reintroduce themTasks:
forms/checks-radiospage to have Approach as the entry point of the page.node-sasscompilation -> Remove it:hasDone list
The following was done in the PR:
To be done after the PR is merged
Motivation & Context
Types of change
Live previews