Skip to content

Conversation

@louismaximepiton
Copy link
Member

@louismaximepiton louismaximepiton commented Apr 1, 2025

Types of change

  • Non-breaking change
  • Breaking change (fix or feature that would change existing functionality and usage)

Related issues

NA

Context & Motivation

Until https://github.com/orgs/community/discussions/4620 is done, it proposes a way to have multiple PR templates.

Description

Add some PR templates for OUDS, in addition to the Boosted ones.

Checklists

  • I have read the contributing guidelines
  • My change follows the developer guide
  • My change pass all tests
  • My change is compatible with a responsive display
  • I have added tests (Javascript unit test or visual) to cover my changes
  • My change introduces changes to the documentation that I have updated accordingly
    • Title and DOM structure is correct
    • Links have been updated (title changes impact links)
    • CSS for the documentation
  • I have checked all states and combinations of the component with my change
  • I have checked all the impacts for the other components and core behavior (grid, reboot, utilities)

Checklist (for Core Team only)

  • The changes need to be in the migration guide
  • The changes are well displayed in Storybook (be careful if example order has changed for DSM)
  • The changes are compatible with RTL
  • Manually test browser compatibility with BrowserStack (Chrome 120, Firefox 121, Edge 120, Safari 15.6, iOS Safari, Chrome & Firefox on Android)

Progression (for Core Team only)

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds multiple Pull Request templates to support both OUDS Web and Boosted development, allowing contributors and core teams to select the template that matches their work.

  • Added release and contribution templates for OUDS Web
  • Added release and contribution templates for Boosted
  • Updated the general PR template to include links for selecting the corresponding templates

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
.github/PULL_REQUEST_TEMPLATE/ouds-release-template.md New release template for OUDS Web with release instructions
.github/PULL_REQUEST_TEMPLATE/ouds-contribution-template.md New contribution template for OUDS Web
.github/PULL_REQUEST_TEMPLATE/boosted-release-template.md New release template for Boosted with release instructions
.github/PULL_REQUEST_TEMPLATE/boosted-contribution-template.md New contribution template for Boosted
.github/PULL_REQUEST_TEMPLATE.md Updated general PR template with links to the new templates

@louismaximepiton louismaximepiton moved this from In Progress / Draft to Need Dev Review in 🟣 [Orange-Boosted-Bootstrap] PRs Board Apr 1, 2025
@netlify
Copy link

netlify bot commented Apr 1, 2025

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit 19106f6
🔍 Latest deploy log https://app.netlify.com/projects/boosted/deploys/6880b341a68e4a0008eb8615
😎 Deploy Preview https://deploy-preview-2937--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@louismaximepiton louismaximepiton marked this pull request as draft April 1, 2025 09:28
@louismaximepiton louismaximepiton marked this pull request as ready for review April 1, 2025 09:29
Copy link
Collaborator

@MaxLardenois MaxLardenois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would propose to go ahead and merge this. We could see how we live with it and make tweaks afterwards if necessary.

Copy link
Collaborator

@MaxLardenois MaxLardenois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually some issues here

@@ -0,0 +1,45 @@
## Release v
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Release v" ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought it as a placeholder, it's to avoid looking at a previous merge how it was done.

@boosted-bot boosted-bot moved this from Need Dev Review to Need Lead Dev Review in 🟣 [Orange-Boosted-Bootstrap] PRs Board Jul 23, 2025
@vprothais vprothais merged commit 02f6477 into main Jul 23, 2025
12 checks passed
@github-project-automation github-project-automation bot moved this from Need Lead Dev Review to Done in 🟣 [Orange-Boosted-Bootstrap] PRs Board Jul 23, 2025
@vprothais vprothais deleted the main-lmp-update-pr-template branch July 23, 2025 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

3 participants