Skip to content

Conversation

@MewenLeHo
Copy link
Contributor

@MewenLeHo MewenLeHo commented Aug 19, 2025

Description

In form example (https://deploy-preview-3097--boosted.netlify.app/docs/5.3/examples/form/), 'Website' is not a required input. Therefore, the required information in the part of the label designed for screen reader users must be removed.

Motivation & Context

Avoid potential confusion for blind users to have a non-mandatory field labelled as mandatory.

Types of change

  • Bug fix (non-breaking which fixes an issue)

Live previews

Checklist

Contribution

Accessibility

  • My change follows accessibility good practices; I have at least run axe

Design

  • My change respects the design guidelines defined in Orange Design System
  • My change is compatible with a responsive display

Development

  • My change follows the developer guide
  • I have added JavaScript unit tests to cover my changes
  • I have added SCSS unit tests to cover my changes

Documentation

  • My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • My change introduces changes to the migration guide
  • My new component is well displayed in Storybook
  • My new component is compatible with RTL
  • Manually run BrowserStack tests
  • Manually test browser compatibility with BrowserStack (Chrome >= 60, Firefox >= 60 (+ ESR), Edge, Safari >= 12, iOS Safari, Chrome & Firefox on Android)
  • Code review
  • Design review
  • A11y review

After the merge

@netlify
Copy link

netlify bot commented Aug 19, 2025

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit d3b809d
🔍 Latest deploy log https://app.netlify.com/projects/boosted/deploys/68a47d8a1be50f000846ff34
😎 Deploy Preview https://deploy-preview-3097--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@MewenLeHo MewenLeHo self-assigned this Aug 19, 2025
Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouups, good catch and thanks for the PR 🙏

@louismaximepiton louismaximepiton merged commit b7d3bcf into Orange-OpenSource:main Aug 20, 2025
14 of 16 checks passed
@github-project-automation github-project-automation bot moved this from In Progress / Draft to Done in 🟣 [Orange-Boosted-Bootstrap] PRs Board Aug 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

2 participants