feat(lib): Remove fonts from the repository#3230
Merged
Conversation
louismaximepiton
added
📖 documentation
github-project-automation
bot
moved this to In Progress / Draft
in 🟣 [Orange-Boosted-Bootstrap] PRs Board
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
boosted-bot
moved this from In Progress / Draft
to Need Dev Review
in 🟣 [Orange-Boosted-Bootstrap] PRs Board
vprothais
reviewed
Dec 1, 2025
| <link rel="preload" href="dist/fonts/HelvNeue55_W1G.woff2" as="font" type="font/woff2" crossorigin="anonymous"> | ||
| ``` | ||
|
|
||
| #### `preconnect` to CDNs |
Collaborator
There was a problem hiding this comment.
Should we add a preconnect for the mastermedia domain from where fonts are going to be loaded ?
Member
Author
There was a problem hiding this comment.
I don't know tbh, the previous ones weren't used, but I can set them back
dist/css/orange-helvetica.css
Outdated
| font-style: normal; | ||
| font-weight: 400; | ||
| src: url("../fonts/HelvNeue55_W1G.woff2") format("woff2") /*rtl:url('../fonts/HelveticaNeueW20-55Roman.woff2') format('woff2')*/; | ||
| src: url("https://mastermedia.dam-broadcast.com/pm_12751_481_481803-rxr62lpoh5.woff2") format("woff2") /*rtl:url('../fonts/HelveticaNeueW20-55Roman.woff2') format('woff2')*/; |
Collaborator
There was a problem hiding this comment.
the rtl part comment is weird, should we rebuild those files ? Shouldn't we have a change also in the rtl file ?
Member
Author
There was a problem hiding this comment.
Idk what happened, I rebuild them and I have a diff 🤷 I must have missed it, good catch
vprothais
approved these changes
Dec 9, 2025
boosted-bot
moved this from Need Dev Review
to Need Lead Dev Review
in 🟣 [Orange-Boosted-Bootstrap] PRs Board
github-project-automation
bot
moved this from Need Lead Dev Review
to Done
in 🟣 [Orange-Boosted-Bootstrap] PRs Board
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: Please transform
- [ ]into- (NA)in the description when things are not applicableRelated issues
Linked to #3224.
Description
Remove Helvetica fonts from the repository.
Motivation & Context
TODO
Types of change
Live previews
Checklist
Contribution
Accessibility
Design
Development
Documentation
Checklist (for Core Team only)
After the merge