-
Notifications
You must be signed in to change notification settings - Fork 56
feat: Add Orange font-face for Helvetica Neue #3255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we update $ouds-font-weights in this PR or not ? It might be tricky since we don't have the same font-weights available between Sosh and Orange.
I think it's maybe missing some information inside typography.mdx
Should we add the used font somewhere in the doc ?
Should we update migration to say that it's new ?
Should we ask a design review on every existing component (even the basic classes) since every single component has changed (between Arial and this one at least)
| $ouds-font-weights: ( | ||
| normal: $ouds-font-weight-system-web-default, | ||
| bold: $ouds-font-weight-system-web-strong | ||
| medium: $ouds-font-weight-system-web-moderate, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I decided to keep the medium value here, since the token exists in Sosh, en just remove the usage in the Sosh documentation. The medium value for Sosh should be ready on design side in the beginning of 2026
louismaximepiton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A small non-mandatory thing and we're good to go !
Types of change
Related issues
Closes #3224
Description
Add Helvetica Neueu font-face with font loaded from CDN
Checklists
Checklist (for Core Team only)
Progression (for Core Team only)
ouds/mainfollowing conventional commitLive previews