Skip to content

Conversation

@vprothais
Copy link
Collaborator

@vprothais vprothais commented Dec 5, 2025

Types of change

  • Non-breaking change
  • Breaking change (fix or feature that would change existing functionality and usage)

Related issues

Closes #3224

Description

Add Helvetica Neueu font-face with font loaded from CDN

Checklists

  • I have read the contributing guidelines
  • My change follows the developer guide
  • My change pass all tests
  • My change is compatible with a responsive display
  • [~] I have added tests (Javascript unit test or visual) to cover my changes
  • My change introduces changes to the documentation that I have updated accordingly
    • Title and DOM structure is correct
    • Links have been updated (title changes impact links)
    • CSS for the documentation
  • [~] I have checked all states and combinations of the component with my change
  • I have checked all the impacts for the other components and core behavior (grid, reboot, utilities)

Checklist (for Core Team only)

  • The changes need to be in the migration guide
  • The changes are well displayed in Storybook (be careful if example order has changed for DSM)
  • The changes are compatible with RTL
  • Manually test browser compatibility with BrowserStack (Chrome 120, Firefox 121, Edge 120, Safari 15.6, iOS Safari, Chrome & Firefox on Android)

Progression (for Core Team only)

Live previews

@netlify
Copy link

netlify bot commented Dec 5, 2025

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit 362a836
🔍 Latest deploy log https://app.netlify.com/projects/boosted/deploys/693c31ccf9e35d0008326d4a
😎 Deploy Preview https://deploy-preview-3255--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we update $ouds-font-weights in this PR or not ? It might be tricky since we don't have the same font-weights available between Sosh and Orange.

I think it's maybe missing some information inside typography.mdx
Should we add the used font somewhere in the doc ?

Should we update migration to say that it's new ?

Should we ask a design review on every existing component (even the basic classes) since every single component has changed (between Arial and this one at least)

@boosted-bot boosted-bot moved this from Need Dev Review to Dev Review In Progress in 🟣 [Orange-Boosted-Bootstrap] PRs Board Dec 10, 2025
$ouds-font-weights: (
normal: $ouds-font-weight-system-web-default,
bold: $ouds-font-weight-system-web-strong
medium: $ouds-font-weight-system-web-moderate,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I decided to keep the medium value here, since the token exists in Sosh, en just remove the usage in the Sosh documentation. The medium value for Sosh should be ready on design side in the beginning of 2026

Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small non-mandatory thing and we're good to go !

@boosted-bot boosted-bot moved this from Dev Review In Progress to Need Lead Dev Review in 🟣 [Orange-Boosted-Bootstrap] PRs Board Dec 12, 2025
@vprothais vprothais merged commit dbfaa89 into ouds/main Dec 15, 2025
11 checks passed
@github-project-automation github-project-automation bot moved this from Need Lead Dev Review to Done in 🟣 [Orange-Boosted-Bootstrap] PRs Board Dec 15, 2025
@vprothais vprothais deleted the ouds/main-vp-orange-font branch December 15, 2025 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

2 participants