-
Notifications
You must be signed in to change notification settings - Fork 58
[OUDS] add max width on native ul and ol #3277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
hannahiss
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| ol, | ||
| ul, | ||
| dl { | ||
| max-width: var(--#{$prefix}font-max-width-body-medium); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it impacted the breadcrumb component, we did not use the list-unstyled there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could use list-unstyled in breadcrumb I think, instead of the padding/list-style none
vprothais
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add also something in migrations guide to talk about this max-width evolution ? Could be relevant for people using boosted, because all their lists will inherit this max-width
Did something |
Types of change
Context & Motivation
Native list in documentation look strange compared to paragraph that have a max-width
Description
Add max-width in reboot ul/ol
Remove it on list-unstyled mixin
Move mixin calls on top of selectors definition
Checklists
Checklist (for Core Team only)
Progression (for Core Team only)
ouds/mainfollowing conventional commitLive previews