Skip to content

Conversation

@MaxLardenois
Copy link
Collaborator

@MaxLardenois MaxLardenois commented Dec 16, 2025

Types of change

  • Non-breaking change
  • Breaking change (fix or feature that would change existing functionality and usage)

Context & Motivation

Native list in documentation look strange compared to paragraph that have a max-width

Description

Add max-width in reboot ul/ol
Remove it on list-unstyled mixin
Move mixin calls on top of selectors definition

Checklists

  • I have read the contributing guidelines
  • My change follows the developer guide
  • My change pass all tests
  • My change is compatible with a responsive display
  • I have added tests (Javascript unit test or visual) to cover my changes
  • My change introduces changes to the documentation that I have updated accordingly
    • Title and DOM structure is correct
    • Links have been updated (title changes impact links)
    • CSS for the documentation
  • I have checked all states and combinations of the component with my change
  • I have checked all the impacts for the other components and core behavior (grid, reboot, utilities)

Checklist (for Core Team only)

  • The changes need to be in the migration guide
  • The changes are well displayed in Storybook (be careful if example order has changed for DSM)
  • The changes are compatible with RTL
  • Manually test browser compatibility with BrowserStack (Chrome 120, Firefox 121, Edge 120, Safari 15.6, iOS Safari, Chrome & Firefox on Android)

Progression (for Core Team only)

Live previews

@netlify
Copy link

netlify bot commented Dec 16, 2025

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit 16662ba
🔍 Latest deploy log https://app.netlify.com/projects/boosted/deploys/6943bead7b2bc9000831392f
😎 Deploy Preview https://deploy-preview-3277--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Member

@hannahiss hannahiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@boosted-bot boosted-bot moved this from Need Dev Review to Need Lead Dev Review in 🟣 [Orange-Boosted-Bootstrap] PRs Board Dec 16, 2025
ol,
ul,
dl {
max-width: var(--#{$prefix}font-max-width-body-medium);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it impacted the breadcrumb component, we did not use the list-unstyled there.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could use list-unstyled in breadcrumb I think, instead of the padding/list-style none

Copy link
Collaborator

@vprothais vprothais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add also something in migrations guide to talk about this max-width evolution ? Could be relevant for people using boosted, because all their lists will inherit this max-width

@boosted-bot boosted-bot moved this from Need Lead Dev Review to Dev Review In Progress in 🟣 [Orange-Boosted-Bootstrap] PRs Board Dec 17, 2025
@MaxLardenois
Copy link
Collaborator Author

Should we add also something in migrations guide to talk about this max-width evolution ? Could be relevant for people using boosted, because all their lists will inherit this max-width

Did something

@boosted-bot boosted-bot moved this from Dev Review In Progress to Need Lead Dev Review in 🟣 [Orange-Boosted-Bootstrap] PRs Board Dec 18, 2025
@vprothais vprothais merged commit 13706cc into ouds/main Dec 18, 2025
11 checks passed
@vprothais vprothais deleted the ouds/main-ml-add-max-width-on-native-ul branch December 18, 2025 08:49
@github-project-automation github-project-automation bot moved this from Need Lead Dev Review to Done in 🟣 [Orange-Boosted-Bootstrap] PRs Board Dec 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

3 participants