fix: brand theme switcher icon #3309
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-project-automation
bot
moved this to In Progress / Draft
in 🟣 [Orange-Boosted-Bootstrap] PRs Board
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
boosted-bot
moved this from In Progress / Draft
to Need Dev Review
in 🟣 [Orange-Boosted-Bootstrap] PRs Board
site/static/orange/docs/[version]/assets/img/ouds-web-sprite.svg
Outdated
Show resolved
Hide resolved
vprothais
requested changes
Jan 5, 2026
Collaborator
vprothais
left a comment
vprothais
left a comment
There was a problem hiding this comment.
There is a conflict on this branch after the merge of the documentation reorganization. We should update this branch with ouds/main
| aria-label={`Toggle brand (${getConfig().brand})`} | ||
| > | ||
| <img src={getVersionedDocsPath(`assets/brand/${getConfig().brand}-logo.svg`)} alt="" loading="lazy" /> | ||
| <svg class:list={['bi ms-auto', { 'd-none': getConfig().brand !== 'orange' }]} aria-hidden="true"> |
Collaborator
There was a problem hiding this comment.
I don't understand the the test to add d-none for other brands. We should have it on any brand.
Member
Author
There was a problem hiding this comment.
Sorry, wrong copy / paste. Fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
Fix #3298
Description
Use theme switcher icon instead of brand icon in header
Motivation & Context
Avoid displaying 2 times the brand icon in the header
Types of change
Live previews
Checklist
Contribution
Accessibility
Design
Development
Documentation
Checklist (for Core Team only)
After the merge