Skip to content

chore: remove add and subtract from SCSS #3321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
MaxLardenois wants to merge 2 commits into
base: ouds/main
Choose a base branch
from
Open

chore: remove add and subtract from SCSS #3321

MaxLardenois wants to merge 2 commits into from

Conversation

@MaxLardenois
Copy link
Collaborator

@MaxLardenois MaxLardenois commented Jan 16, 2026 •
edited
Loading

Types of change

  • Non-breaking change
  • Breaking change (fix or feature that would change existing functionality and usage)

Context & Motivation

add and subtract are no longer useful, removing them in our codebase also permits to use the sass modules commits from bootstrap v6.

Description

Use calc instead of add and subtract everywhere
Remove eslint rule on calc

Checklists

  • I have read the contributing guidelines
  • My change follows the developer guide
  • My change pass all tests
  • My change is compatible with a responsive display
  • I have added tests (Javascript unit test or visual) to cover my changes
  • My change introduces changes to the documentation that I have updated accordingly
    • Title and DOM structure is correct
    • Links have been updated (title changes impact links)
    • CSS for the documentation
  • I have checked all states and combinations of the component with my change
  • I have checked all the impacts for the other components and core behavior (grid, reboot, utilities)

Checklist (for Core Team only)

  • The changes need to be in the migration guide
  • The changes are well displayed in Storybook (be careful if example order has changed for DSM)
  • The changes are compatible with RTL
  • Manually test browser compatibility with BrowserStack (Chrome 120, Firefox 121, Edge 120, Safari 15.6, iOS Safari, Chrome & Firefox on Android)

Progression (for Core Team only)

Live previews

@mdo @MaxLardenois
v6: Don't disallow calc (#41681)
7d98597 
* Don't disallow calc()

* Remove disables that aren't needed

* Remove custom subtract and add functions

* Remove more disables

* keep it here
@netlify
Copy link

netlify bot commented Jan 16, 2026 •
edited
Loading

✅ Deploy Preview for boosted ready!

Name Link
🔨 Latest commit ee859f0
🔍 Latest deploy log https://app.netlify.com/projects/boosted/deploys/696a3487a66e6e000892883d
😎 Deploy Preview https://deploy-preview-3321--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@MaxLardenois MaxLardenois marked this pull request as ready for review January 16, 2026 10:21
@boosted-bot boosted-bot moved this from In Progress / Draft to Need Dev Review in 🟣 [Orange-Boosted-Bootstrap] PRs Board Jan 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

🟣 [Orange-Boosted-Bootstrap] PRs Board
Status: Need Dev Review

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MaxLardenois @mdo