Open
Conversation
github-project-automation
bot
moved this to In Progress / Draft
in 🟣 [Orange-Boosted-Bootstrap] PRs Board
boosted-bot
moved this from In Progress / Draft
to Need Dev Review
in 🟣 [Orange-Boosted-Bootstrap] PRs Board
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
MaxLardenois
reviewed
Feb 5, 2026
Collaborator
MaxLardenois
left a comment
MaxLardenois
left a comment
There was a problem hiding this comment.
I have questions about the roles on footer and banner
| </svg> | ||
|
|
||
| <header class="sticky-top" data-bs-theme="dark"> | ||
| <header class="sticky-top" data-bs-theme="dark" role="banner"> |
Collaborator
There was a problem hiding this comment.
element has a banner role by default (except if it is inside another semantic element, but it's not the case here)
| </main> | ||
|
|
||
| <footer class="footer navbar" data-bs-theme="dark"> | ||
| <footer class="footer navbar" data-bs-theme="dark" role="contentinfo"> |
Collaborator
There was a problem hiding this comment.
Same question as banner on header, footer has a contentinfo role by default
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
NA
Description
Add some unique roles that might be an issue in the future to better convey information to ATs.
Checklists
Progression (for Core Team only)
ouds/mainfollowing conventional commitLive previews