Skip to content

[OUDS] fix(download app page): Improve accessibility#3337

Open
hannahiss wants to merge 3 commits intoouds/mainfrom
ouds/main-his-download-app-a11y
Open

[OUDS] fix(download app page): Improve accessibility#3337
hannahiss wants to merge 3 commits intoouds/mainfrom
ouds/main-his-download-app-a11y

Conversation

@hannahiss
Copy link
Member

@hannahiss hannahiss commented Feb 4, 2026

Types of change

  • Non-breaking change
  • Breaking change (fix or feature that would change existing functionality and usage)

Related issues

Closes #3330

Context & Motivation

Improve accessibility (after Vincent Aniort review) and enhance use of components and utilities

Description

Fix some accessibility issues:

  • the QR code has an aria-labelledby pointing toward nothing => it is pointing to the SVG title (first tag inside the <svg>. It works well with NVDA and Talkback) Is it allright to keep it that way @Aniort?
  • perhaps the QR code should enlarge with the zoom text only => ok, size is now set in rem (the image is not so big in 200% text zoom so it seems ok to enlarge it)
  • add aria-hidden for the whole carousel => ok, aria-hidden added plus alt texts on images removed

Some other enhancements:

  • remove useless xmlns="http://www.w3.org/2000/svg", since it is already set in the first <svg> tag, and the other are pointing on it
  • replace old class hxl-md-icon by a correct one (decorative-xlarge-icon)
  • replace old class bl-md-icon by a correct one (decorative-medium-icon)
  • remove useless width and height attributes since they are set by icon size utilities classes
  • remove useless (and non-existing) btn-large class
  • remove useless class me-2xsmallon icons inside buttons
  • use an icon size utility class when it was not the case

Checklists

  • I have read the contributing guidelines
  • My change follows the developer guide
  • My change pass all tests
  • My change is compatible with a responsive display
  • I have added tests (Javascript unit test or visual) to cover my changes
  • My change introduces changes to the documentation that I have updated accordingly
    • Title and DOM structure is correct
    • Links have been updated (title changes impact links)
    • CSS for the documentation
  • I have checked all states and combinations of the component with my change
  • I have checked all the impacts for the other components and core behavior (grid, reboot, utilities)

Checklist (for Core Team only)

  • The changes need to be in the migration guide
  • The changes are well displayed in Storybook (be careful if example order has changed for DSM)
  • The changes are compatible with RTL
  • Manually test browser compatibility with BrowserStack (Chrome 120, Firefox 121, Edge 120, Safari 15.6, iOS Safari, Chrome & Firefox on Android)

Progression (for Core Team only)

Live previews

@netlify
Copy link

netlify bot commented Feb 4, 2026

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit 10311c0
🔍 Latest deploy log https://app.netlify.com/projects/boosted/deploys/69832e271edf7d00080af898
😎 Deploy Preview https://deploy-preview-3337--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@hannahiss hannahiss marked this pull request as ready for review February 4, 2026 12:48
@boosted-bot boosted-bot moved this from In Progress / Draft to Need Dev Review in 🟣 [Orange-Boosted-Bootstrap] PRs Board Feb 4, 2026
Copy link
Collaborator

@MaxLardenois MaxLardenois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@boosted-bot boosted-bot moved this from Need Dev Review to Need Lead Dev Review in 🟣 [Orange-Boosted-Bootstrap] PRs Board Feb 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Need Lead Dev Review

Development

Successfully merging this pull request may close these issues.

3 participants