Skip to content

[OUDS] Show password example#3410

Open
hannahiss wants to merge 22 commits intoouds/mainfrom
ouds/main-his-show-passwd
Open

[OUDS] Show password example#3410
hannahiss wants to merge 22 commits intoouds/mainfrom
ouds/main-his-show-passwd

Conversation

@hannahiss
Copy link
Copy Markdown
Member

@hannahiss hannahiss commented Mar 4, 2026

Related issues

Description

Add show password live example in paswword input page

Checklists

Progression (for Core Team only)

Live previews

@hannahiss hannahiss changed the title Show password example [OUDS] Show password example Mar 4, 2026
@netlify
Copy link
Copy Markdown

netlify bot commented Mar 4, 2026

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit 5fed7da
🔍 Latest deploy log https://app.netlify.com/projects/boosted/deploys/69d67e7211a87300092972c0
😎 Deploy Preview https://deploy-preview-3410--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@hannahiss hannahiss marked this pull request as ready for review March 5, 2026 09:08
@boosted-bot boosted-bot moved this from In Progress / Draft to Need Dev Review in 🟣 [Orange-Boosted-Bootstrap] PRs Board Mar 5, 2026
@hannahiss
Copy link
Copy Markdown
Member Author

A thought for the reviewer: if we put the “accessibility-no-vision” icon in the OUDS Web sprite, we could have icons that change with the brand in the example (like loading buttons), but this icon is not strictly necessary for the OUDS documentation...

@hannahiss hannahiss marked this pull request as draft March 9, 2026 09:39
@hannahiss hannahiss marked this pull request as ready for review March 23, 2026 09:04
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances the Password input documentation by adding a JavaScript-powered “show/hide password” live example (including a new “hide” icon in the shared SVG sprite), and includes a small documentation wording fix elsewhere.

Changes:

  • Add a new “Show password” live example section to the Password input docs and wire it to a JS snippet.
  • Introduce a new hide icon symbol in OUDS SVG sprites for the Orange / Orange Compact / Sosh doc sites.
  • Fix “JavaScript” capitalization in the migration guide.

Reviewed changes

Copilot reviewed 3 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
site/static/sosh/docs/[version]/assets/img/ouds-web-sprite.svg Adds hide icon symbol to support toggling icon in docs examples.
site/static/orange/docs/[version]/assets/img/ouds-web-sprite.svg Adds hide icon symbol to support toggling icon in docs examples.
site/static/orange-compact/docs/[version]/assets/img/ouds-web-sprite.svg Adds hide icon symbol to support toggling icon in docs examples.
site/src/content/docs/getting-started/migration-from-boosted.mdx Fixes “JavaScript” capitalization in explanatory text.
site/src/content/docs/components/password-input.mdx Adds JS guidance + a live example wired to the snippets file.
site/src/assets/partials/snippets.js Adds the click handler used by the new live example.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The whole thing work good, I'm just wondering if we should vocalize the password once we show the password ?

@boosted-bot boosted-bot moved this from Need Dev Review to Need Lead Dev Review in 🟣 [Orange-Boosted-Bootstrap] PRs Board Apr 3, 2026
@hannahiss
Copy link
Copy Markdown
Member Author

hannahiss commented Apr 8, 2026

The whole thing work good, I'm just wondering if we should vocalize the password once we show the password ?

I found this article which suggests something about that: https://technology.blog.gov.uk/2021/04/19/simple-things-are-complicated-making-a-show-password-option/#:~:text=Screen%20reader%20users,to%20do%20so. However, it can be overkilling on that simple example... We have to discuss that.

Some other recommendations for security are to set the type of the filed back to "password" when submitting... Should we mention that somewhere too?

@hannahiss
Copy link
Copy Markdown
Member Author

I also found something about the label which maybe shouldn't be changed: https://medium.com/@web-accessibility-education/dos-and-donts-of-accessible-show-password-buttons-9a5fbc2c566b#:~:text=Don%E2%80%99t%3A%20Toggle%20both,and%20vice%20versa.

So many questions now ??? 😲

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Need Lead Dev Review

Development

Successfully merging this pull request may close these issues.

5 participants