Skip to content

Conversation

pya35
Copy link
Member

@pya35 pya35 commented Jun 25, 2025

Copy link

netlify bot commented Jun 25, 2025

Deploy Preview for a11y-guidelines ready!

Name Link
🔨 Latest commit e5ba953
🔍 Latest deploy log https://app.netlify.com/projects/a11y-guidelines/deploys/68832f753955b4000887032e
😎 Deploy Preview https://deploy-preview-737--a11y-guidelines.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@pya35 pya35 requested review from Aniort and MewenLeHo June 25, 2025 16:06
@pya35

This comment was marked as outdated.

@pya35 pya35 marked this pull request as ready for review June 25, 2025 16:07
MewenLeHo

This comment was marked as outdated.

@pya35 pya35 requested a review from MewenLeHo June 27, 2025 15:54
@pya35
Copy link
Member Author

pya35 commented Jun 27, 2025

Good job. I just added some suggestions to help improve english but it's not mandatory. Do we need to add a warning about the differences between aria-disabled="true" and disabled?

good question

MewenLeHo

This comment was marked as outdated.

@Aniort

This comment was marked as outdated.

@pya35
Copy link
Member Author

pya35 commented Jul 15, 2025

@Aniort ready to review with read-only paragraph

Copy link
Collaborator

@Aniort Aniort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ça me va

@pya35 pya35 requested a review from MewenLeHo July 21, 2025 15:05
Copy link
Collaborator

@MewenLeHo MewenLeHo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for the added part about readonly.
I just have a small question about the examples displayed in this part.

@MewenLeHo MewenLeHo self-requested a review July 23, 2025 08:55
@MewenLeHo MewenLeHo added the ready Ready for relase label Jul 25, 2025
@pya35
Copy link
Member Author

pya35 commented Jul 25, 2025

Thanks for review! Next step: english version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready Ready for relase update article
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants