Fix single quote in cookie value breaking curl output#4879
Conversation
|
Hi @eyupcanakman thanks for the PR and sorry for the late response. Would you be kind to sign your commit to pass the CI/CD checks? (see CONTRIBUTING.md), your commit should look like this:
|
e47851a to
8e90545
Compare
|
@jcamiel done, sorry about that |
|
/accept |
|
🕗 /accept is running, please wait for completion. |
|
🔨 Auto rebase from |
|
🕗 /accept is still running, please wait for completion. |
8e90545 to
03277b8
Compare
|
❌ Some checks are still failing, please fix them before trying to merge this pull request. |
|
/accept |
|
🕗 /accept is running, please wait for completion. |
|
🔨 Auto rebase from
|
|
🕗 /accept is still running, please wait for completion. |
03277b8 to
16a11fe
Compare
|
❌ Some checks are still failing, please fix them before trying to merge this pull request. |
|
/accept |
|
🕗 /accept is running, please wait for completion. |
|
✅ Pull request merged with fast forward by
|

Cookie values containing single quotes produced broken curl commands because the value was wrapped with naive single quotes.
Use the existing
encode_shell_stringfunction for the --cookie argument, which switches to $'...' quoting when needed.Fixes #4557