Skip to content

Fix single quote in cookie value breaking curl output#4879

Merged
hurl-bot merged 1 commit intoOrange-OpenSource:masterfrom
eyupcanakman:fix/cookie-single-quote-curl-4557
Mar 22, 2026
Merged

Fix single quote in cookie value breaking curl output#4879
hurl-bot merged 1 commit intoOrange-OpenSource:masterfrom
eyupcanakman:fix/cookie-single-quote-curl-4557

Conversation

@eyupcanakman
Copy link
Contributor

Cookie values containing single quotes produced broken curl commands because the value was wrapped with naive single quotes.

Use the existing encode_shell_string function for the --cookie argument, which switches to $'...' quoting when needed.

Fixes #4557

@jcamiel
Copy link
Collaborator

jcamiel commented Mar 22, 2026

Hi @eyupcanakman thanks for the PR and sorry for the late response.

Would you be kind to sign your commit to pass the CI/CD checks? (see CONTRIBUTING.md), your commit should look like this:

sign-commit

@eyupcanakman eyupcanakman force-pushed the fix/cookie-single-quote-curl-4557 branch from e47851a to 8e90545 Compare March 22, 2026 16:15
@eyupcanakman
Copy link
Contributor Author

@jcamiel done, sorry about that

@jcamiel
Copy link
Collaborator

jcamiel commented Mar 22, 2026

/accept

@hurl-bot
Copy link
Collaborator

🕗 /accept is running, please wait for completion.

@hurl-bot
Copy link
Collaborator

🔨 Auto rebase from Orange-OpenSource/hurl/master succeeds, eyupcanakman/hurl/fix/cookie-single-quote-curl-4557 now embeds these commits:

  • 01ede76 Update CHANGELOG
  • 41753fd Replace legacy env var variable configuration HURL_foo by HURL_VARIABLE_foo
  • 0522afa Detect Invalid JSONPath regex at JSONPath parsing
  • 3e177bd Use specific regex argument for match/search functions
  • 4679dd8 Add invalid literal for regex param

@hurl-bot
Copy link
Collaborator

🕗 /accept is still running, please wait for completion.

@hurl-bot hurl-bot force-pushed the fix/cookie-single-quote-curl-4557 branch from 8e90545 to 03277b8 Compare March 22, 2026 16:26
@hurl-bot
Copy link
Collaborator

❌ Some checks are still failing, please fix them before trying to merge this pull request.

@jcamiel
Copy link
Collaborator

jcamiel commented Mar 22, 2026

/accept

@hurl-bot
Copy link
Collaborator

🕗 /accept is running, please wait for completion.

@hurl-bot
Copy link
Collaborator

🔨 Auto rebase from Orange-OpenSource/hurl/master succeeds, eyupcanakman/hurl/fix/cookie-single-quote-curl-4557 now embeds these commits:

  • 73f5315 Support delay configuration by setting HURL_DELAY env var.

@hurl-bot
Copy link
Collaborator

🕗 /accept is still running, please wait for completion.

@hurl-bot hurl-bot force-pushed the fix/cookie-single-quote-curl-4557 branch from 03277b8 to 16a11fe Compare March 22, 2026 16:49
@hurl-bot
Copy link
Collaborator

❌ Some checks are still failing, please fix them before trying to merge this pull request.

@jcamiel
Copy link
Collaborator

jcamiel commented Mar 22, 2026

/accept

@hurl-bot
Copy link
Collaborator

🕗 /accept is running, please wait for completion.

@hurl-bot
Copy link
Collaborator

✅ Pull request merged with fast forward by jcamiel..

# List of commits merged from eyupcanakman/hurl/fix/cookie-single-quote-curl-4557 branch into Orange-OpenSource/hurl/master branch:

  • 16a11fe Fix single quote in cookie value breaking curl output

@hurl-bot hurl-bot merged commit 16a11fe into Orange-OpenSource:master Mar 22, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Single quote in cookie value make invalid curl debug command

3 participants