feat(top-app-bar): add the option to add a badge on an icon in the top app bar #969
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florentmaitre
changed the title
🟢 Netlify deploy for commit a28c918 succeededDeploy preview: https://693990a14efe47f5e2be802b--ouds-android.netlify.app |
florentmaitre
force-pushed
the
968-add-the-option-to-add-a-badge-on-an-icon-in-the-top-app-bar-design-is-available-on-figma
branch
from
c3a0633 to
17e7e84
Compare
florentmaitre
force-pushed
the
968-add-the-option-to-add-a-badge-on-an-icon-in-the-top-app-bar-design-is-available-on-figma
branch
from
17e7e84 to
71e75f0
Compare
florentmaitre
force-pushed
the
968-add-the-option-to-add-a-badge-on-an-icon-in-the-top-app-bar-design-is-available-on-figma
branch
from
4faa0ff to
3bc3f75
Compare
florentmaitre
had a problem deploying
to
netlify
GitHub Actions
Failure
paulinea
requested changes
Dec 10, 2025
core/src/main/java/com/orange/ouds/core/component/OudsButton.kt
Outdated
Show resolved
Hide resolved
core/src/main/java/com/orange/ouds/core/component/OudsButton.kt
Outdated
Show resolved
Hide resolved
core/src/main/java/com/orange/ouds/core/component/OudsButton.kt
Outdated
Show resolved
Hide resolved
paulinea
deleted the
968-add-the-option-to-add-a-badge-on-an-icon-in-the-top-app-bar-design-is-available-on-figma
branch
florentmaitre
added a commit
that referenced
this pull request
Dec 11, 2025
…p app bar (#969) * Add OudsComponentIconBadge and an icon badge parameter in OudsButton * Add snapshot tests for OudsButton with icon badge * Add OudsBadgedIcon and use it in OudsNavigationBarItem * Add snapshot tests for OudsBadgedIcon * Add OudsTopAppBarActionBadge * Add top app bar action badge to the demo screen * Add KDoc to OudsBadgedIcon * Fix accessibility on OudsBadgedIcon * Various fixes * Fix layout of standard OudsBadgedIcon in RTL * Review: Remove guard condition in when * Review: Change appearance of button to minimal in icon badge preview
florentmaitre
added a commit
that referenced
this pull request
Dec 11, 2025
…p app bar (#969) * Add OudsComponentIconBadge and an icon badge parameter in OudsButton * Add snapshot tests for OudsButton with icon badge * Add OudsBadgedIcon and use it in OudsNavigationBarItem * Add snapshot tests for OudsBadgedIcon * Add OudsTopAppBarActionBadge * Add top app bar action badge to the demo screen * Add KDoc to OudsBadgedIcon * Fix accessibility on OudsBadgedIcon * Various fixes * Fix layout of standard OudsBadgedIcon in RTL * Review: Remove guard condition in when * Review: Change appearance of button to minimal in icon badge preview
florentmaitre
added a commit
that referenced
this pull request
Dec 11, 2025
…p app bar (#969) * Add OudsComponentIconBadge and an icon badge parameter in OudsButton * Add snapshot tests for OudsButton with icon badge * Add OudsBadgedIcon and use it in OudsNavigationBarItem * Add snapshot tests for OudsBadgedIcon * Add OudsTopAppBarActionBadge * Add top app bar action badge to the demo screen * Add KDoc to OudsBadgedIcon * Fix accessibility on OudsBadgedIcon * Various fixes * Fix layout of standard OudsBadgedIcon in RTL * Review: Remove guard condition in when * Review: Change appearance of button to minimal in icon badge preview
paulinea
pushed a commit
that referenced
this pull request
Dec 15, 2025
…p app bar (#969) * Add OudsComponentIconBadge and an icon badge parameter in OudsButton * Add snapshot tests for OudsButton with icon badge * Add OudsBadgedIcon and use it in OudsNavigationBarItem * Add snapshot tests for OudsBadgedIcon * Add OudsTopAppBarActionBadge * Add top app bar action badge to the demo screen * Add KDoc to OudsBadgedIcon * Fix accessibility on OudsBadgedIcon * Various fixes * Fix layout of standard OudsBadgedIcon in RTL * Review: Remove guard condition in when * Review: Change appearance of button to minimal in icon badge preview
paulinea
pushed a commit
that referenced
this pull request
Dec 15, 2025
* Add OudsTopAppBar # Conflicts: # NOTICE.txt # core/src/main/java/com/orange/ouds/core/component/OudsTag.kt # theme-contract/src/main/java/com/orange/ouds/theme/OudsDrawableResources.kt # theme-orange/src/main/java/com/orange/ouds/theme/orange/OrangeDrawableResources.kt # theme-sosh/src/main/java/com/orange/ouds/theme/sosh/SoshDrawableResources.kt # theme-wireframe/src/main/java/com/orange/ouds/theme/wireframe/WireframeDrawableResources.kt # Conflicts: # core/src/main/java/com/orange/ouds/core/component/OudsTag.kt * Add design version to navigation and top app bars * Add top app bar demo * Add translucent parameter to top app bar * Integrate OudsTopAppBar into the demo app * Add snapshot tests * Add instrumented tests * Rename NavigationBar to Bar in OudsVersion * Monogram is now limited to a single letter and does not take user font scale into account * Fix a crash in typography tokens screen * Review: Fix KDoc * Review: Rename size parameter of Title method to topAppBarSize to avoid confusion * Review: It is now possible to customize the top app bar demo with all kind of navigation icons * Review: Replace hardcoded 48dp with minInteractiveArea token value * Review: Remove empty line * Review: Factorize top padding and window insets of top bars * feat(top-app-bar): add the option to add a badge on an icon in the top app bar (#969) * Add OudsComponentIconBadge and an icon badge parameter in OudsButton * Add snapshot tests for OudsButton with icon badge * Add OudsBadgedIcon and use it in OudsNavigationBarItem * Add snapshot tests for OudsBadgedIcon * Add OudsTopAppBarActionBadge * Add top app bar action badge to the demo screen * Add KDoc to OudsBadgedIcon * Fix accessibility on OudsBadgedIcon * Various fixes * Fix layout of standard OudsBadgedIcon in RTL * Review: Remove guard condition in when * Review: Change appearance of button to minimal in icon badge preview
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.