Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds the Bullet List component to the design system toolbox, enabling users to view related text items grouped together with numbers, bullets, or as bare lists.
Changes:
- Adds new Bullet List component with configuration options for type (unordered/ordered/bare), text style, nesting levels, and styling
- Implements snapshot tests for Bullet List across all themes (Orange, Sosh, OrangeBusinessTools, Wireframe)
- Fixes existing typos in Badge snapshot test method names and comments across multiple theme files
Reviewed changes
Copilot reviewed 17 out of 788 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| BulletListSnapshotsTestsTestCase.swift | Defines base test case for BulletList snapshot testing with comprehensive parameter coverage |
| SoshTheme+BulletListSnapshotsTests.swift | Implements SoshTheme-specific BulletList snapshot tests |
| OrangeTheme+BulletListSnapshotsTests.swift | Implements OrangeTheme-specific BulletList snapshot tests |
| OrangeBusinessToolsTheme+BulletListSnapshotsTests.swift | Implements OrangeBusinessToolsTheme-specific BulletList snapshot tests |
| Localizable.xcstrings | Adds localization strings for BulletList component labels and descriptions |
| BulletListPage.swift | Implements the main BulletList demo page with configuration integration |
| BulletListElement.swift | Defines the BulletList component element for the design toolbox |
| BulletListConfigurationView.swift | Implements configuration UI and model for customizing BulletList parameters |
| ComponentsPage.swift | Registers BulletListElement in the components list |
| Package.resolved | Updates swift-custom-dump dependency and OUDS iOS branch reference |
| project.pbxproj | Adds BulletList source files to Xcode project targets |
| ContentDisplay.md | Creates placeholder markdown file for ContentDisplay documentation |
| CHANGELOG.md | Documents the addition of Bullet List component |
| BadgeSnapshotsTests.swift (multiple themes) | Fixes typo in method/comment names from "bages" to "badges" |
| BadgeConfigurationView.swift | Updates localization key reference for type label |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...ots__/Components/Test Cases/Components/ContentDisplay/BulletListSnapshotsTestsTestCase.swift
Outdated
Show resolved
Hide resolved
...ots__/Components/Test Cases/Components/ContentDisplay/BulletListSnapshotsTestsTestCase.swift
Outdated
Show resolved
Hide resolved
...ots__/Components/Test Cases/Components/ContentDisplay/BulletListSnapshotsTestsTestCase.swift
Outdated
Show resolved
Hide resolved
...ots__/Components/Test Cases/Components/ContentDisplay/BulletListSnapshotsTestsTestCase.swift
Show resolved
Hide resolved
...ots__/Components/Test Cases/Components/ContentDisplay/BulletListSnapshotsTestsTestCase.swift
Outdated
Show resolved
Hide resolved
...ts__/Components/SoshTheme/Components/ContentDisplay/SoshTheme+BulletListSnapshotsTests.swift
Outdated
Show resolved
Hide resolved
...ts__/Components/SoshTheme/Components/ContentDisplay/SoshTheme+BulletListSnapshotsTests.swift
Outdated
Show resolved
Hide resolved
43e58a7 to
a21ad75
Compare
b38ebb9 to
8924e70
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 20 out of 793 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
DesignToolbox/DesignToolbox/Pages/Components/Indicators/Badge/BadgeConfigurationView.swift
Show resolved
Hide resolved
DesignToolbox/DesignToolbox.xcworkspace/xcshareddata/swiftpm/Package.resolved
Show resolved
Hide resolved
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
…Source/ouds-ios#513) Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
…Source/ouds-ios#513) Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
…nge-OpenSoruce/ouds-ios#513) Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
4d4d64e to
409b848
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: Please transform
- [ ]into- (NA)in the description when things are not applicableRelated issues
(Orange-OpenSource/ouds-ios#513)
Description
Motivation & Context
Types of change
Previews
Checklist
Contribution
Accessibility
Design
Development
Documentation
Checklist (for Core Team only)