Skip to content

[#513] Add Bullet List component#182

Open
ludovic35 wants to merge 25 commits intodevelopfrom
513-component-create-component---bullet-list
Open

[#513] Add Bullet List component#182
ludovic35 wants to merge 25 commits intodevelopfrom
513-component-create-component---bullet-list

Conversation

@ludovic35
Copy link
Member

@ludovic35 ludovic35 commented Jan 28, 2026

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

(Orange-OpenSource/ouds-ios#513)

Description

Motivation & Context

Types of change

  • New feature (non-breaking change which adds functionality)

Previews

Checklist

Contribution

Accessibility

  • My change follows accessibility good practices

Design

  • My change respects the design guidelines of Orange Unified Design System

Development

  • My change follows the developer guide
  • I checked my changes do not add new SwiftLint warnings
  • I have added unit tests to cover my changes (optional)

Documentation

  • My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • The evolution have been tested and the project builds for iPhones and iPads
  • Code review has been done by reviewers according to CODEOWNERS file
  • Design review has been done
  • Accessibility review has been done
  • Q/A team has tested the evolution
  • Documentation has been updated if relevant
  • Internal files have been updated if relevant (like CONTRIBUTING, DEVELOP, THIRD_PARTY, CONTRIBUTORS, NOTICE)
  • CHANGELOG has been updated respecting keep a changelog rules and reference the issues
  • The wiki has been updated if needed (optional)

@ludovic35 ludovic35 marked this pull request as ready for review January 29, 2026 08:16
@ludovic35 ludovic35 requested a review from pylapp as a code owner January 29, 2026 08:16
@pylapp pylapp self-assigned this Jan 29, 2026
@pylapp pylapp requested a review from Copilot January 29, 2026 14:42
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds the Bullet List component to the design system toolbox, enabling users to view related text items grouped together with numbers, bullets, or as bare lists.

Changes:

  • Adds new Bullet List component with configuration options for type (unordered/ordered/bare), text style, nesting levels, and styling
  • Implements snapshot tests for Bullet List across all themes (Orange, Sosh, OrangeBusinessTools, Wireframe)
  • Fixes existing typos in Badge snapshot test method names and comments across multiple theme files

Reviewed changes

Copilot reviewed 17 out of 788 changed files in this pull request and generated 8 comments.

Show a summary per file
File Description
BulletListSnapshotsTestsTestCase.swift Defines base test case for BulletList snapshot testing with comprehensive parameter coverage
SoshTheme+BulletListSnapshotsTests.swift Implements SoshTheme-specific BulletList snapshot tests
OrangeTheme+BulletListSnapshotsTests.swift Implements OrangeTheme-specific BulletList snapshot tests
OrangeBusinessToolsTheme+BulletListSnapshotsTests.swift Implements OrangeBusinessToolsTheme-specific BulletList snapshot tests
Localizable.xcstrings Adds localization strings for BulletList component labels and descriptions
BulletListPage.swift Implements the main BulletList demo page with configuration integration
BulletListElement.swift Defines the BulletList component element for the design toolbox
BulletListConfigurationView.swift Implements configuration UI and model for customizing BulletList parameters
ComponentsPage.swift Registers BulletListElement in the components list
Package.resolved Updates swift-custom-dump dependency and OUDS iOS branch reference
project.pbxproj Adds BulletList source files to Xcode project targets
ContentDisplay.md Creates placeholder markdown file for ContentDisplay documentation
CHANGELOG.md Documents the addition of Bullet List component
BadgeSnapshotsTests.swift (multiple themes) Fixes typo in method/comment names from "bages" to "badges"
BadgeConfigurationView.swift Updates localization key reference for type label

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ludovic35 ludovic35 force-pushed the 513-component-create-component---bullet-list branch from 43e58a7 to a21ad75 Compare January 29, 2026 15:23
Copy link
Member

@pylapp pylapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ludovic35 ludovic35 force-pushed the 513-component-create-component---bullet-list branch from b38ebb9 to 8924e70 Compare February 2, 2026 08:23
@pylapp pylapp requested a review from Copilot February 2, 2026 17:49
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 20 out of 793 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…nge-OpenSoruce/ouds-ios#513)

Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp pylapp force-pushed the 513-component-create-component---bullet-list branch from 4d4d64e to 409b848 Compare February 4, 2026 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants