Skip to content

[#887] Update button version 3.0 #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Aug 19, 2025
Merged

[#887] Update button version 3.0 #47

merged 11 commits into from
Aug 19, 2025

Conversation

ludovic35
Copy link
Member

@ludovic35 ludovic35 commented Aug 6, 2025 •
edited by pylapp
Loading

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

Orange-OpenSource/ouds-ios#887

Description

Motivation & Context

Types of change

  • New feature (non-breaking change which adds functionality)

Previews

Checklist

Contribution

Accessibility

  • My change follows accessibility good practices

Design

  • My change respects the design guidelines of Orange Unified Design System

Development

  • My change follows the developer guide
  • I checked my changes do not add new SwiftLint warnings
  • I checked I am using the last version of OUDS iOS library
  • I have added unit tests to cover my changes (optional)

Documentation

  • My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • The evolution have been tested and the project builds for iPhones and iPads
  • Code review has been done by reviewers according to CODEOWNERS file
  • Design review has been done
  • Accessibility review has been done
  • Q/A team has tested the evolution
  • Documentation has been updated if relevant
  • Internal files have been updated if relevant (like CONTRIBUTING, DEVELOP, THIRD_PARTY, CONTRIBUTORS, NOTICE)
  • CHANGELOG has been updated respecting keep a changelog rules and reference the issues

@ludovic35 ludovic35 requested a review from pylapp as a code owner August 6, 2025 12:53
@pylapp pylapp self-assigned this Aug 19, 2025
@pylapp pylapp merged commit 56d8eff into develop Aug 19, 2025
14 of 16 checks passed
@pylapp pylapp deleted the 887-component-update-button-version-30 branch August 19, 2025 16:39
pylapp added a commit that referenced this pull request Aug 19, 2025
@ludovic35 @pylapp
refactor: update button component (version 3.0) (Orange-OpenSource/…
c45a7c7 
…ouds-ios#887) (#47)

Related to Orange-OpenSource/ouds-ios#887

Reviewed-by: Pierre-Yves Lapersonne <[email protected]>
Co-authored-by: Ludovic Pinel <[email protected]>
Co-authored-by: Pierre-Yves Lapersonne <[email protected]>
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pylapp pylapp Awaiting requested review from pylapp pylapp is a code owner

Assignees

@pylapp pylapp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ludovic35 @pylapp