Rename ouds-prefixed public View methods and internal OUDSButtonStyle#1371
Open
Rename ouds-prefixed public View methods and internal OUDSButtonStyle#1371
ouds-prefixed public View methods and internal OUDSButtonStyle#1371Conversation
7 tasks
…tton Agent-Logs-Url: https://github.com/Orange-OpenSource/ouds-ios/sessions/1e08d090-da57-4d99-bb37-f7e5698a17ce Co-authored-by: pylapp <7559007+pylapp@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Rename public methods and change OUDSButtonStyle
Rename Mar 27, 2026
ouds-prefixed public View methods and internal OUDSButtonStyle
22221f5 to
38099a5
Compare
Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com>
38099a5 to
9be8886
Compare
11 tasks
Member
|
Note @ludovic35 This PR must be merged before the one in design toolbox side (https://github.com/Orange-OpenSource/ouds-ios-design-system-toolbox/pull/2161) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User feedback indicated the
oudsprefix on view modifier methods was verbose and redundant given that OUDS token parameter types provide unambiguous overload resolution vs. native SwiftUI APIs.Changes
Deprecated
ouds-prefixedViewextensions → new unprefixed equivalents:.oudsForegroundStyle(_:).foregroundStyle(_:).oudsForegroundColor(_:).foregroundColor(_:).oudsBackground(_:).background(_:).oudsAccentColor(_:).accentColor(_:).oudsShadow(_:).shadow(_:).oudsBorder(style:width:radius:color:).border(style:width:radius:color:).oudsColoredSurface(_:).coloredSurface(_:).oudsGridMargin(_:).gridMargin(_:).oudsRequestAccessibleFocus(_:).requestAccessibleFocus(_:).oudsRequestAccessibleFocus(_:for:).requestAccessibleFocus(_:for:).oudsHorizontalDivider(dividerColor:).horizontalDivider(dividerColor:).oudsVerticalDivider(color:).verticalDivider(color:)Old methods are marked
@available(*, deprecated, renamed:)and forward to the new names — no breaking change.oudsNavigationTitleintentionally excluded —Stringconforms toStringProtocol, so a barenavigationTitle(_:)would shadow SwiftUI's standard modifier at call sites.Internal rename:
OUDSButtonStyle→StyleForButton(not public API).No ambiguity with SwiftUI overloads — OUDS token types (
MultipleColorSemanticToken,MultipleElevationCompositeRawToken, etc.) are distinct from SwiftUI protocol types (ShapeStyle,Color?, etc.)..doccdocumentation updatedRelated issues
Description
See above.
Motivation & Context
Align
Viewmodifier naming with the existing typography helper convention (displayLarge(_:),headingMedium(_:), etc.) and reduce API verbosity per user feedback.Types of change
Previews
(NA)
Checklist
Contribution
Accessibility
Design
Development
Documentation
Checklist (for Core Team only)
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.