Skip to content

[#956] Remove button trait for filter chip and add toggle trait if iOS 17+#966

Draft
pylapp wants to merge 1 commit intodevelopfrom
956-buga11y-filter-chip-component-should-have-a-toggle-role-instead-of-a-button
Draft

[#956] Remove button trait for filter chip and add toggle trait if iOS 17+#966
pylapp wants to merge 1 commit intodevelopfrom
956-buga11y-filter-chip-component-should-have-a-toggle-role-instead-of-a-button

Conversation

@pylapp
Copy link
Copy Markdown
Member

@pylapp pylapp commented Sep 17, 2025 •
edited
Loading

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Caution

Need review and acknowledgment of @pya35 before merge!

Related issues

#956

Description

Apply suitable traits for filter chip component

Motivation & Context

Types of change

  • Bug fix (non-breaking which fixes an issue)

Previews

Checklist

Contribution

Accessibility

  • My change follows accessibility good practices

Design

  • My change respects the design guidelines of Orange Unified Design System

Development

  • My change follows the developer guide
  • I checked my changes do not add new SwiftLint warnings
  • I have added unit tests to cover my changes (optional)

Documentation

  • My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • The evolution have been tested and the project builds for iPhones and iPads
  • Code review has been done by reviewers according to CODEOWNERS file
  • (NA) Design review has been done
  • Accessibility review has been done
  • (NA) Q/A team has tested the evolution
  • Documentation has been updated if relevant
  • Internal files have been updated if relevant (like CONTRIBUTING, DEVELOP, THIRD_PARTY, CONTRIBUTORS, NOTICE)
  • CHANGELOG has been updated respecting keep a changelog rules and reference the issues
  • The wiki has been updated if needed (optional)

@pylapp
fix: remove button trait for filter chip and add toggle trait if iO…
b53cdaf 
…S 17+ (#956)

Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com>
@pylapp pylapp linked an issue Sep 17, 2025 that may be closed by this pull request
For filter chip component it should have a toggle role instead of a button #956
Open
1 task
@pylapp pylapp requested a review from ludovic35 as a code owner September 17, 2025 12:33
@pylapp pylapp marked this pull request as draft September 17, 2025 12:35
ludovic35
ludovic35 requested changes Sep 17, 2025
View reviewed changes
OUDS/Core/Components/Sources/Controls/Chip/OUDSFilterChip.swift
/// Thus an hint is automatically added and a custom hint is not needed anymore/
private var accessibilityHint: String {
(selected ? "core_filterchip_hint_selected_a11y" : "core_filterchip_hint_unselected_a11y").localized()
if #available(iOS 17.0, *) {
Copy link
Copy Markdown
Member

@ludovic35 ludovic35 Sep 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Est-ce que l'on ne pouvais pas faire ceci dans le modifier ?
et avec le clef de wording core_common_selected_a11y ?
Et utiliser pour le radio et peut -êttre le picker ?

@pylapp pylapp force-pushed the develop branch 2 times, most recently from 359407c to 6fa9080 Compare October 6, 2025 11:17
@pylapp pylapp force-pushed the develop branch 2 times, most recently from ad3ed96 to 2f1e2c0 Compare October 14, 2025 13:08
@pylapp pylapp force-pushed the develop branch 4 times, most recently from 61fb35f to 56b76ff Compare November 3, 2025 11:16
@pylapp pylapp force-pushed the develop branch 3 times, most recently from eb93f6a to 9bab815 Compare December 17, 2025 15:56
@pylapp pylapp force-pushed the develop branch 4 times, most recently from 10d28fe to fe7b9f4 Compare January 9, 2026 16:00
@pylapp pylapp force-pushed the develop branch 6 times, most recently from 59b1f19 to 9aff4f0 Compare January 19, 2026 17:39
@pylapp pylapp force-pushed the develop branch 2 times, most recently from 9597a53 to f8ea75e Compare February 20, 2026 16:08
@pylapp pylapp force-pushed the develop branch 6 times, most recently from cc5191c to 4546101 Compare March 18, 2026 10:36
@pylapp pylapp force-pushed the develop branch 3 times, most recently from d85a25d to 20c2b2b Compare March 31, 2026 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ludovic35 ludovic35 ludovic35 requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@ludovic35 ludovic35

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

For filter chip component it should have a toggle role instead of a button

2 participants

@pylapp @ludovic35