Conversation
✅ Deploy Preview for keen-davinci-769980 canceled.
|
❌ Deploy Preview for verdant-souffle-6c4e17 failed.
|
❌ Deploy Preview for romantic-ride-755295 failed.
|
isaksolheim
left a comment
There was a problem hiding this comment.
Oki I have some things I noticed! But super nice that we have somebody working on this now 🎆
U have added new dependencies at root in the project, when this repo is split into two separate project (/sanity) and (/frontend), so everything sanity related should be done in /sanity.
the .sanity folder should be added to the .gitignore
also seems like someone once used yarn at root in the project, the yarn.lock there can just be removed
isaksolheim
left a comment
There was a problem hiding this comment.
.sanity is still checked in, and even more packages was added to package.json 😬 this can all be removed
isaksolheim
left a comment
There was a problem hiding this comment.
hmm there is still a very huge diff on the package-lock.json file in the root of the project, did u remember to run npm i after removing the dependencies from package.json? 🤔
|
but other than that I think ur good! but you should check the logs from netlify and try to figure out why everything is red 🔴 |
OBS OBS VÆR EKSTREMT SKEPTISK