Split map SVG into separate route #538
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sea-kelp
commented
Mar 22, 2025
Comment on lines
+26
to
+27
| <img alt="Map of states with departments in OpenOversight" | ||
| src="{{ url_for('main.render_map') }}" /> |
Collaborator
Author
There was a problem hiding this comment.
Using <img> here which renders it non-interactively on the front page
| {% endif %} | ||
| {% endfor %} | ||
| </svg> | ||
| <object type="image/svg+xml" data="{{ url_for('main.render_map') }}"></object> |
Collaborator
Author
There was a problem hiding this comment.
Using <object> here to embed the SVG interactively on the browse page
| </defs> | ||
| {% for state, path in map_paths.items() %} | ||
| {% if state in departments_by_state.keys() %} | ||
| <a href="{{ url_for('main.browse') }}#state-{{ state }}" target="_top"> |
Collaborator
Author
There was a problem hiding this comment.
Setting target="_top" here to open the link in the top-level browser rather than only in the <object> frame
3 tasks
AetherUnbound
approved these changes
Apr 19, 2025
Collaborator
AetherUnbound
left a comment
AetherUnbound
left a comment
There was a problem hiding this comment.
Sweet, looks great!
github-project-automation
bot
moved this from 📋 Backlog
to ✅ Done
in Orca Collective Task Tracker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Split map SVG into a separate route that can be reused
Notes for Deployment
None!
Screenshots (if appropriate)
N/A (Same as before)
Testing instructions
Checks
I have rebased my changes on
mainjust lintpassesjust testpasses