#8056: Adapting MySqlCommandInterpreter to 767 character length limitation

[mazuryv]

#8056
767 length limitation in mysql

[sebastienros]

LGTM. But needs @BenedekFarkas and @MatteoPiovanelli

[mazuryv]

Without these changes recipe was fallen for me in Orchard.Recipes.Migrations
table.CreateIndex("IDX_RecStResRec_ExecId_StepN", "ExecutionId", "StepName");
MySqlServer 8.0.40/8.0.41

[sebastienros]

LGTM but someone should validate it too. Or add a functional test.

[BenedekFarkas]

LGTM but someone should validate it too. Or add a functional test.

I'll test it locally.

[BenedekFarkas]

I'm trying to test this, but having problems completing the setup with a MySQL version (5.7.44) that is supposed to be compatible with the MySQL connector we're using (6.7.9).

Docker:

Run: docker run --name mysql -p 3307:3306 -e MYSQL_ROOT_PASSWORD=password -e MYSQL_DATABASE=Orchard -d mysql:5.7.44
Connection string: Server=localhost;Port=3307;Database=Orchard;Uid=root;Pwd=password;SslMode=None

Local server:

Connection string: Server=localhost;Port=3306;Database=orchard;Uid=root;Pwd=password;SslMode=None

Error (same for both):

MySql.Data.MySqlClient.MySqlException: 'You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '(NOLOCK) inner join Title_TitlePartRecord titlepartr2_ WITH(NOLOCK) on this_.Id=' at line 1'

Docker images with more recent versions have different errors.

@mazuryv what version of MySQL are you using? Did you experience any similar errors?

[mazuryv]

Hello.
I have updated MySQL connector MySql.Data nuget package up to 9.2.0 to be compatible with current MySqlServer 8.0.40/8.0.41+
Thank you.

[BenedekFarkas]

OK, that's a pretty important detail. :)

Are there any other changes to your code/application that isn't in the PR branch? I can't get the setup to complete unless NoLockInterceptor is "neutralized" by not modifying the SQL statement.

[BenedekFarkas]

We need additional verification from someone who already uses MySQL to make sure we don't break existing applications + I still can't get the setup to work in this state, so any additional testing and extra set of eyes are welcome.

[BenedekFarkas]

I managed to test this and verify that the changes work, however, only if:

• NoLockInterceptor is changed not to modify commands if the database provider is not SQL Server or SQL CE. This is already included in #8859: Fixing setup errors with PostgreSQL and MySQL #8861.
• DistributedLockSchemaBuilder is modified so that the Name column has only a length of 255. Anything above that throws an error, see Fixing setup errors with PostgreSQL and MySQL #8859.

I'll look into upgrading MySql.Data in #8859.