#8266: Security sensitive permissions (Lombiq Technologies: ORCH-214)#8874
Merged
BenedekFarkas merged 15 commits intoOrchardCMS:devfrom Nov 27, 2025
Merged
#8266: Security sensitive permissions (Lombiq Technologies: ORCH-214)#8874BenedekFarkas merged 15 commits intoOrchardCMS:devfrom
BenedekFarkas merged 15 commits intoOrchardCMS:devfrom
Conversation
… Security Critical permissions
…issions / roles + code styling
BenedekFarkas
requested changes
Nov 26, 2025
Co-authored-by: Benedek Farkas <benedek.farkas@lombiq.com>
BenedekFarkas
requested changes
Nov 27, 2025
BenedekFarkas
approved these changes
Nov 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #8266
Here, I tried to mimic what we currently have in Orchard Core. It means we have a badge with the "Security Critical" text and a tooltip that reads "This permission could allow a user to elevate their other permissions. Grant it with extreme consideration.". It appears before each Allow checkbox when setting up a role's permissions. We also have a hint on that page describing the differences between the Allow and Effective settings.
In this PR, I have added the same hint to describe the Allow and Effective settings. We have an icon with an exclamation mark instead of a badge, and I used the exact text for the tooltip, as you can see in Orchard Core.
The tooltip text is the same as in Orchard Core.
I didn't want to include too much styling, so I used an icon from Font Awesome with the title HTML attribute.