Introduce OrchardCore.Testing APIs #13018
Conversation
# Conflicts: # src/OrchardCore/OrchardCore.Testing/Apis/Security/PermissionContextAuthorizationHandler.cs # src/OrchardCore/OrchardCore.Testing/Data/TablePrefixGenerator.cs # src/OrchardCore/OrchardCore.Testing/Extensions/HttpContentExtensions.cs # test/OrchardCore.Testing.Tests/Data/TablePrefixGeneratorTests.cs # test/OrchardCore.Testing.Tests/Security/PermissionHandlerTests.cs # test/OrchardCore.Tests/Apis/ContentManagement/ContentApiController/BlogPostApiControllerTests.cs # test/OrchardCore.Tests/Apis/ContentManagement/DeploymentPlans/BlogPostCreateDeploymentPlanTests.cs # test/OrchardCore.Tests/Apis/ContentManagement/DeploymentPlans/BlogPostUpdateDeploymentPlanTests.cs # test/OrchardCore.Tests/Apis/Context/BlogPostApiControllerContext.cs # test/OrchardCore.Tests/Apis/Context/Extensions/HttpRequestExtensions.cs # test/OrchardCore.Tests/Apis/Context/MvcTestFixture.cs # test/OrchardCore.Tests/Apis/Context/SiteContext.cs # test/OrchardCore.Tests/Apis/Context/SiteStartup.cs # test/OrchardCore.Tests/Apis/Context/TestRecipeHarvester.cs # test/OrchardCore.Tests/Apis/GraphQL/ValidationRules/RequiresPermissionValidationRuleTests.cs # test/OrchardCore.Tests/Apis/Lucene/LuceneQueryTests.cs # test/OrchardCore.Tests/DisplayManagement/Decriptors/DefaultShapeTableManagerTests.cs # test/OrchardCore.Tests/DisplayManagement/DefaultDisplayManagerTests.cs # test/OrchardCore.Tests/DisplayManagement/ShapeFactoryTests.cs # test/OrchardCore.Tests/DisplayManagement/ShapeHelperTests.cs # test/OrchardCore.Tests/DisplayManagement/ShapeSerializerTests.cs # test/OrchardCore.Tests/Email/EmailTests.cs # test/OrchardCore.Tests/Extensions/ExtensionManagerTests.cs # test/OrchardCore.Tests/Localization/PortableObjectStringLocalizerFactoryTests.cs # test/OrchardCore.Tests/Localization/PortableObjectStringLocalizerTests.cs # test/OrchardCore.Tests/Modules/OrchardCore.OpenId/OpenIdServerDeploymentSourceTests.cs # test/OrchardCore.Tests/Modules/OrchardCore.Roles/RolesPermissionsHandlerTests.cs # test/OrchardCore.Tests/OrchardCore.Users/UserValidatorTests.cs # test/OrchardCore.Tests/OrchardCore.Users/UsersMockHelper.cs # test/OrchardCore.Tests/ResourceManagement/ResourceDefinitionTests.cs # test/OrchardCore.Tests/ResourceManagement/ResourceManagerTests.cs # test/OrchardCore.Tests/Routing/AutorouteEntriesTests.cs # test/OrchardCore.Tests/Security/PermissionHandlerHelper.cs # test/OrchardCore.Tests/Shell/ShellContainerFactoryTests.cs # test/OrchardCore.Tests/Stubs/MemoryFileBuilder.cs # test/OrchardCore.Tests/Stubs/StubExtensionManager.cs # test/OrchardCore.Tests/Stubs/StubHostingEnvironment.cs # test/OrchardCore.Tests/Stubs/StubPoFileLocationProvider.cs # test/OrchardCore.Tests/Workflows/WorkflowManagerTests.cs
|
Hello @hishamco, is there anything else I can do to contribute to this PR? |
|
Sorry @MichaelPetrinolis for late I will try to make this as a top of my ToDo list |
|
It seems that this pull request didn't really move for quite a while. Is this something you'd like to revisit any time soon or should we close? Please comment if you'd like to pick it up. |
|
for instructions on how to resolve the merge conflicts due to #16572 please follow the step listed in this comment. |
|
It seems that this pull request didn't really move for quite a while. Is this something you'd like to revisit any time soon or should we close? Please comment if you'd like to pick it up. |
|
Closing this pull request because it has been stale for very long. If you think this is still relevant, feel free to reopen it. |
|
It seems that this pull request didn't really move for quite a while. Is this something you'd like to revisit any time soon or should we close? Please comment if you'd like to pick it up. |
|
Closing this pull request because it has been stale for very long. If you think this is still relevant, feel free to reopen it. |
|
Hello @hishamco, is this PR abandoned? |
|
Seems it closed as stale PR, let's recheck again, coz it was almost ready except the docs |
|
@MichaelPetrinolis I know you & I wanna merge this from a while, if you have any feedback on this, let me know, otherwise I will fix the conflict |
|
Hi @hishamco , i was using this lib to test it, What I saw is that for proper initialization and to avoid deadlocks we need to create a Fixture for each context we test (an IAsyncLifetime implementation that initializes and disposes the sitecontext). Then, a test class should implement IClassFixture and get the context from there. |
|
@hishamco are you able to complete this PR? Keeping these PR open for so long obviously causes lots of conflicts and wasted effort. |
|
It seems that this pull request didn't really move for quite a while. Is this something you'd like to revisit any time soon or should we close? Please comment if you'd like to pick it up. |
|
Closing this pull request because it has been stale for very long. If you think this is still relevant, feel free to reopen it. |
This is one of the PRs that I'm working on testing part of Orchard Core, the plan is to provide an essential testing APIs infrastructure for creating unit tests easily for OC APIs and modules
For reference #11865 (comment)
Fixes #11865.