-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Including GraphQL support for the GeoPointField #18175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you for submitting your first pull request, awesome! 🚀 If you haven't already, please take a moment to review our contribution guide. This guide provides helpful information to ensure your contribution aligns with our standards. A core team member will review your pull request. If you like Orchard Core, please star our repo and join our community channels. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good addition, thank you.
src/OrchardCore.Modules/OrchardCore.Spatial/OrchardCore.Spatial.csproj
Outdated
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.Spatial/GrapgQL/GeoPointFieldQueryObjectType.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.Spatial/GrapgQL/GeoPointFieldProvider.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.Spatial/GrapgQL/GeoPointFieldProvider.cs
Outdated
Show resolved
Hide resolved
Thank you too, I fixed the issues you mentioned. Anyway most of the code is adapted from some other module. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one more thing, there is a spelling error in the namespace.
That one is fixed as well, thanks for pointing it down 🙂 May I ask for some suggestion on how to implement WHERE filter, with the regular by latitude or by longitude or both and additional option to set radius (example: to fetch all the points in an area). |
If I remember correctly, this is handled separately for content fields. The implementation resides in the Specifically, you should implement However, it appears that these providers are currently only available within the module itself and not exposed through an Abstractions assembly. This means additional work is required to refactor and move the relevant functionality into an Abstractions or Core project to make it reusable and properly structured. |
@RNovachkov please accept the license agreement. |
How? I clicked the link added Microsoft GitHub Policy Service, selected the project and confirmed everything (Thanks for the GeoPointField response) |
Follow the description here: #18175 (comment) |
@dotnet-policy-service agree |
src/OrchardCore.Modules/OrchardCore.Spatial/GraphQL/GeoPointFieldProvider.cs
Outdated
Show resolved
Hide resolved
@gvkries any reason why this isn’t merged yet? Please merge it if it is ready to be |
For more information: #12744 (comment)
(check the latest comments from april 2025)
@dotnet-policy-service agree