docs: add AnchorTagHelper documentation to Media module#18817
docs: add AnchorTagHelper documentation to Media module#18817Manuel-dev-ing wants to merge 2 commits intoOrchardCMS:mainfrom
Conversation
|
Thank you for submitting your first pull request, awesome! 🚀 If you haven't already, please take a moment to review our contribution guide. This guide provides helpful information to ensure your contribution aligns with our standards. A core team member will review your pull request. If you like Orchard Core, please star our repo and join our community channels. |
|
@dotnet-policy-service agree |
Piedone
left a comment
Piedone
left a comment
There was a problem hiding this comment.
Thank you, but these are actually documented now: https://docs.orchardcore.net/en/latest/reference/modules/Media/#razor-image-resizing-tag-helpers. Would you like to update that section instead?
|
Sure, I'd like to work on that section. But I have a question, since this change request seeks to address the issue: "The new AnchorTagHelper in the multimedia module should be documented in #7005." Is it poorly worded and therefore not addressing a real need? |
|
The issue is outdated. I'd assume that somebody added the docs section and didn't know about the issue (after all, we have a lot). |
|
Actually, I think the issue is still valid. Only the |
| The AnchorTagHelper in the Media module allows you to generate links (`<a>`) to files in the Media Library using logical paths, automatically resolving the correct URL. | ||
|
|
||
|
|
||
| `asset-src` attribute is used to specify a logical path in the Media Library. It will be converted to a public href URL at render time.. e.g.: |
There was a problem hiding this comment.
Typo? Should be asset-href, right?
There was a problem hiding this comment.
Yes, it's a typo, it should be: asset-href.
|
@Piedone. Could you let me know about the update to the section you mentioned? What exactly do I need to update? |
|
I was wrong, sorry, indeed a new section is needed. |
3 participants
This PR adds documentation for the AnchorTagHelper in the Media module.
Fixes: #7005