WIP Ethena sUSDe <> USDe ARM #147
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add EthenaARM integration tests and shared setup * Rename test file * Add integration tests for swapTokensForExactTokens functionality in EthenaARM * Refactor swapExactTokensForTokens tests for clarity and correctness * Remove unused IERC721Receiver import from EthenaARM contract
* Enhance EthenaARM to support multiple unstaker contracts for parallel cooldown requests * Fix type casting for last used unstaker index to ensure proper indexing * Simplify array management * Implement request delay for unstake requests and update visibility of state variables * Refactor comments in EthenaARM contract for clarity and consistency * Remove unused imports and clean up comments in EthenaARM contract * Refactor EthenaARM contract to use constant for maximum unstakers and update related code for clarity
naddison36
commented
Nov 14, 2025
src/contracts/EthenaARM.sol
Outdated
| require(unstaker != address(0), "EthenaARM: Invalid unstaker"); | ||
|
|
||
| // Ensure unstaker isn't used during last 7 days | ||
| uint256 amount = EthenaUnstaker(unstaker).cooldownAmount(); |
Collaborator
Author
There was a problem hiding this comment.
this can call cooldowns on sUSDe directly rather than going via the helper
src/contracts/EthenaARM.sol
Outdated
| /// @notice Claim all the USDe that is now claimable from the Staked USDe contract. | ||
| /// Reverts with `InvalidCooldown` from the Staked USDe contract if the cooldown period has not yet passed. | ||
| function claimBaseWithdrawals(address unstaker) external { | ||
| uint256 cooldownAmount = EthenaUnstaker(unstaker).cooldownAmount(); |
Collaborator
Author
There was a problem hiding this comment.
this can call cooldowns on sUSDe directly rather than going via the helper
src/contracts/EthenaUnstaker.sol
Outdated
| susde.unstake(arm); | ||
| } | ||
|
|
||
| function cooldownAmount() external view returns (uint256) { |
Collaborator
Author
There was a problem hiding this comment.
I think we can drop this function. The ARM can get the cooldown amount for the unstaker directly
* wip add unstaker deployment script * Refactor deployUnstakers function to use constant for max unstakers * Rename setUnstaker function to setUnstakers for clarity * Deploy unstakers and set ownership in DeployEthenaARMScript * Make unstakers array public for improved accessibility * Add tests for request/claim withdraw * Add more test for request/claim * Fix error message for request delay in requestBaseWithdrawal function * Simplify cooldown amount handling in EthenaARM contract * Add tests for swapping SUSDE to USDE with outstanding withdrawals and insufficient liquidity * Refactor cooldown handling in EthenaARM and EthenaUnstaker contracts to use UserCooldown struct * Refactor import statements in DeployEthenaARMScript to consolidate IWETH and IStakedUSDe imports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Ethena's synthetic dollar, USDe, provides the crypto-native, scalable solution for money achieved by delta-hedging Bitcoin, Ethereum and other governance-approved spot assets using perpetual and deliverable futures contracts, as well as holding liquid stables such as USDC and USDT.
USDe can be staked to receive protocol rewards. sUSDe is the liquidity provider token received when staking USDe. There is a 7 day cooling off period to unstake sUSDe which means sUSDe trades with a discount in the market.
Objectives/Requirements
Links
ARM Configuration