Skip to content

Conversation

@clement-ux
Copy link
Collaborator

@clement-ux clement-ux commented Jan 9, 2026

Description

Merge VaultAdmin and VaultCore.

  • This PR remove the old proxy implementation, where VaultCore delegated calls to VaultAdmin. Now VaultAdmin directly inherit from VaultCore.
  • This allow a simpler inherance graph, less hurdles to understand how contracts relationship works.
  • This PR renames previous vaults to only OTokenVault.
  • This PR migrate zapper to dedicated folder.

Before:
Capture d’écran 2026-01-09 à 17 45 07
After
Capture d’écran 2026-01-09 à 17 45 21

@codecov
Copy link

codecov bot commented Jan 9, 2026

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 35.27%. Comparing base (8b073b8) to head (80a0ffa).
⚠️ Report is 7 commits behind head on clement/simplify-ousd.

Files with missing lines Patch % Lines
contracts/contracts/vault/OETHPlumeVault.sol 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                    Coverage Diff                    @@
##           clement/simplify-ousd    #2743      +/-   ##
=========================================================
- Coverage                  35.51%   35.27%   -0.24%     
=========================================================
  Files                        128      125       -3     
  Lines                       5471     5451      -20     
  Branches                    1443     1440       -3     
=========================================================
- Hits                        1943     1923      -20     
  Misses                      3527     3527              
  Partials                       1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@clement-ux clement-ux marked this pull request as ready for review January 12, 2026 12:51
Copy link
Collaborator

@naddison36 naddison36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is excellent. Thanks

@naddison36 naddison36 merged commit e05bb2a into clement/simplify-ousd Jan 12, 2026
14 of 17 checks passed
@naddison36 naddison36 deleted the clement/simplify-ousd-merge-vaultcore-and-vaultadmin branch January 12, 2026 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants