ci: swap nyc with c8 for unit test coverage reports#31
Merged
radomir-sebek merged 1 commit intov8/developfrom Jun 6, 2025
Merged
ci: swap nyc with c8 for unit test coverage reports#31radomir-sebek merged 1 commit intov8/developfrom
radomir-sebek merged 1 commit intov8/developfrom
Conversation
Bojan131
reviewed
Jun 4, 2025
Contributor
Bojan131
left a comment
There was a problem hiding this comment.
This looks great i really like it. We can talk about expanding these to other repos on the QA Guild. Lets wait for Mihajlo to also take a look and approve if everything is ok on his side
Collaborator
Author
Thank you, sure, lets see if @Mihajlo-Pavlovic gives thumbs up here, I would love to merge it soon :) |
Mihajlo-Pavlovic
approved these changes
Jun 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two improvements come with this PR:
requiresystem. By looking at test/*.test.js I can see code instrumented as ESM (withimport ... from ...), so it NYC cannot instrument source files, at least not right away so I would need to use additional loader or similar.before:


after:
html reporterand exposed calculated artefacts so they can be accessible also on demandPS. If there is ever desired to require minimum coverage threshold, one can set check-coverage to true and "demand" /instrument line coverage, or any of (functions, statements, branches) to not go bellow specified threshold. For now, its disabled.