Merged
Conversation
zsculac
reviewed
May 19, 2025
Comment on lines
+160
to
-179
| # Create a single Dataset | ||
| g = Graph() | ||
| try: | ||
| g.parse(data=all_nquads, format="nt") | ||
| except RDFParserError: | ||
| raise UnsupportedJSON_LD(nquads_list) | ||
|
|
||
| # Get the triple and replace blank nodes | ||
| for s, p, o in g: | ||
| updated_quad = ( | ||
| replace_blank_node(s), | ||
| replace_blank_node(p), | ||
| replace_blank_node(o), | ||
| ) | ||
| # Format as N-Quad string | ||
| result.append( | ||
| f"{updated_quad[0].n3()} {updated_quad[1].n3()} {updated_quad[2].n3()} ." | ||
| ) |
Collaborator
There was a problem hiding this comment.
I don't remember exactly why but there was a reason why we processed nquad by nquad and created a graph for each. This lib works differently than what we use in js. Did you thorougly test the new implementation?
Contributor
Author
There was a problem hiding this comment.
The implementation is not the same as in JavaScript. The last implementation had a bug in it, regarding the processing of the nquads one by one. It was tested with both error inducing JSON-LDs and valid ones.
zsculac
reviewed
May 19, 2025
zsculac
approved these changes
May 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.