ON-1026-Land-Parcel-Profit-Share#9
Open
EduardoMelo00 wants to merge 10 commits intoAGIP-94-land-parcelsfrom
Open
ON-1026-Land-Parcel-Profit-Share#9EduardoMelo00 wants to merge 10 commits intoAGIP-94-land-parcelsfrom
EduardoMelo00 wants to merge 10 commits intoAGIP-94-land-parcelsfrom
Conversation
ernanirst
requested changes
Nov 5, 2024
| ); | ||
| } | ||
|
|
||
| function _handleTokenChanneling(uint256 _realmId, bytes32 _roleId, uint256 channelAmount, uint256 tokenIndex) internal { |
There was a problem hiding this comment.
This function, seems unnecessary. Was it extracted because of the stack too deep error? I think almost all of these variables can be removed
Author
There was a problem hiding this comment.
Yes, this was extracted because of the stack too deep error, all the internal function was created due the stack too deep
| _realmId | ||
| ); | ||
|
|
||
| alchemica.mint(LibAlchemica.alchemicaRecipient(_gotchiId), splitCalc.borrowerAmount); |
There was a problem hiding this comment.
Isn't the alchemica already transferred to the borrower via splitter?
Author
There was a problem hiding this comment.
In this case just to you know, i didn't change this function. I kept because in the new Splitter we don't consider the borrowerAmount because this should be transferred out of split, as we talked first.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.