Skip to content

fix issue #15 #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
huicaikrz wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix issue #15 #20

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions SyntheticControlMethods/optimize.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ def total_loss(self, v_0,
data.in_time_placebo_w = w.value

#Return loss
return loss
return loss.flatten()

def _get_dsc_outcome(self, w, control_outcome, periods_pre_treatment, treated_pretreatment_outcome):
'''Method used only by DiffSynth (DSC)
Expand Down Expand Up @@ -307,4 +307,4 @@ def random_optimize(self, steps=10**4):

#Store, print, return best solutions
self.w = best_w
return best_w, min_loss
return best_w, min_loss